Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find-plan does not catch the error when the name contains non alphanumeric character #12

Open
tayruxin opened this issue Nov 17, 2023 · 1 comment

Comments

@tayruxin
Copy link
Owner

tayruxin commented Nov 17, 2023

When I attempt to find for a plan by entering find-plan --john, the app does not respond. When checking the terminal there seem to be an illegal argument exception that was not handled by the app. This was accounted in the find-friend command.

image.png

It is not rare for users to key in a non-alphanumeric character by accident.

@soc-se-bot
Copy link

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

While it does provide inconvenience to the users to have to clear their command, and retype a correct command before proceeding. We feel that it should only be of low severity due to the following reasons:

  • It will not affect most users as most users will look at their friends (friend names must be alphanumeric) available first, then find-plan by the shown names, so the likelihood of searching --john is not as frequent.
  • Keying in this command does not crash the application, and stop the user from proceeding to use this application. Just by clearing the command and typing other commands, the user can continue to use FriendBook, hence this problem does not make the application 'almost unusable' for the user.

Items for the Tester to Verify

❓ Issue severity

Team chose [severity.Low]
Originally [severity.High]

  • I disagree

Reason for disagreement: [replace this with your reason]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants