Add tests for Intl.PluralRules.prototype.resolvedOptions().pluralCategories order
#4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egories` order Array elements should appear in following order: "zero", "one", "two", "few", "many", "other" see tc39/ecma402#918
ben-allen
force-pushed
the
pluralrules-sort-order-pr-918
branch
from
2b9b41b
to
18e3e85
Compare
Ms2ger
reviewed
Nov 1, 2024
Comment on lines
13
to
14
| includes: [compareArray.js] | ||
| ---*/ |
There was a problem hiding this comment.
Does this not need a locale: [...] tag?
There was a problem hiding this comment.
fixed! (also alphabetized the locales just to be doing it)
| assert.compareArray(new Intl.PluralRules('ar').resolvedOptions().pluralCategories, ['zero', 'one', 'two', 'few', 'many', 'other'], "pluralCategories order or contents incorrect for 'ar' locale"); | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Please remove the spurious empty lines
There was a problem hiding this comment.
You seem to have missed the one between ko and sl, I'm afraid
There was a problem hiding this comment.
Sigh. Sorry about that, should be fixed now
…uralCategories` order
…ns().pluralCategories` order
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Nov 26, 2024
…olvedOptions. r=spidermonkey-reviewers,dminor Sort plural categories per <tc39/ecma402#918>. Tests are in <tc39/test262#4275>. Differential Revision: https://phabricator.services.mozilla.com/D228569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array elements should appear in following order: "zero", "one", "two", "few", "many", "other"
see tc39/ecma402#918
fix #4261