treewide: include core/format.hh when appropriate

before this change, we include core/print.hh for formatting and/or for printing. but core/print.hh includes `<iostream>` which is a heavyweight header in the C++ standard library. under most circumstances, all we need is but `seastar::format()`, which is provided by a smaller header -- `core/format.hh`. in this change, we include `core/format.hh` instead of `core/print.hh` when appropriate. and adapt the translation units where `iostream` is used to include this header. this should reduce the header dependency of Seastar library and speed up the compilation. Signed-off-by: Kefu Chai <[email protected]>
tchaikov · Nov 4, 2024 · d145145 · d145145
1 parent 812c945
commit d145145
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 4 deletions.
diff --git a/apps/io_tester/ioinfo.cc b/apps/io_tester/ioinfo.cc
@@ -18,6 +18,7 @@
 /*
  * Copyright (C) 2021 ScyllaDB
  */
+#include <iostream>
 #include <seastar/core/app-template.hh>
 #include <seastar/core/thread.hh>
 #include <seastar/core/reactor.hh>

diff --git a/apps/rpc_tester/rpc_tester.cc b/apps/rpc_tester/rpc_tester.cc
@@ -19,6 +19,7 @@
  * Copyright (C) 2022 ScyllaDB
  */
 
+#include <iostream>
 #include <vector>
 #include <chrono>
 #include <random>

diff --git a/demos/rpc_demo.cc b/demos/rpc_demo.cc
@@ -19,6 +19,7 @@
  * Copyright 2015 Cloudius Systems
  */
 #include <cmath>
+#include <iostream>
 #include <ranges>
 #include <seastar/core/reactor.hh>
 #include <seastar/core/app-template.hh>

diff --git a/include/seastar/core/internal/estimated_histogram.hh b/include/seastar/core/internal/estimated_histogram.hh
@@ -25,8 +25,8 @@
 #include <algorithm>
 #include <vector>
 #include <chrono>
+#include <string>
 #include <seastar/core/metrics_types.hh>
-#include <seastar/core/print.hh>
 #include <seastar/core/bitops.hh>
 #include <limits>
 #include <array>

diff --git a/include/seastar/rpc/rpc_impl.hh b/include/seastar/rpc/rpc_impl.hh
@@ -20,14 +20,14 @@
  */
 #pragma once
 
+#include <seastar/core/format.hh>
 #include <seastar/core/function_traits.hh>
 #include <seastar/core/shared_ptr.hh>
 #include <seastar/core/sstring.hh>
 #include <seastar/core/when_all.hh>
 #include <seastar/util/is_smart_ptr.hh>
 #include <seastar/core/simple-stream.hh>
 #include <seastar/net/packet-data-source.hh>
-#include <seastar/core/print.hh>
 
 #include <boost/type.hpp> // for compatibility
 

diff --git a/include/seastar/util/backtrace.hh b/include/seastar/util/backtrace.hh
@@ -21,8 +21,8 @@
 
 #pragma once
 
+#include <seastar/core/format.hh>
 #include <seastar/core/sstring.hh>
-#include <seastar/core/print.hh>
 #include <seastar/core/scheduling.hh>
 #include <seastar/core/shared_ptr.hh>
 #include <seastar/util/modules.hh>

diff --git a/include/seastar/util/program-options.hh b/include/seastar/util/program-options.hh
@@ -21,8 +21,8 @@
 
 #pragma once
 
+#include <seastar/core/format.hh>
 #include <seastar/core/sstring.hh>
-#include <seastar/core/print.hh>
 #include <seastar/util/modules.hh>
 
 #ifndef SEASTAR_MODULE

diff --git a/src/net/dpdk.cc b/src/net/dpdk.cc
@@ -26,6 +26,7 @@ module;
 
 #include <cinttypes>
 #include <atomic>
+#include <iostream>
 #include <vector>
 #include <queue>
 #include <getopt.h>