Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailto: link with multiple emails (and potentially a subject) isn't handled correctly #378

Open
DanielYang59 opened this issue Nov 29, 2024 · 4 comments

Comments

@DanielYang59
Copy link

It looks mailto: link with multiple emails (and potentially a subject) might not have been handled correctly,

The links has the following format (I removed the real email addresses for privacy concerns, but if there emails addresses are necessary to recreate this you could check here, it's public):

mailto:user_a@address,[email protected],[email protected]?subject=someSubjectOfTheEmail

And I got the following error:

[✖] mailto:user_a@address,[email protected],[email protected]?subject=someSubjectOfTheEmail → Status: 400

I'm not sure if this is an isemail issue though, but I noticed it's no longer maintained:

This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

@MikeMcC399
Copy link

@DanielYang59

I'm not sure if this is an isemail issue though, but I noticed it's no longer maintained:

@DanielYang59
Copy link
Author

Hi Mike,

Thanks for letting me know. I don't know much about the internal working of markdown-link-check so not sure if I should propagate the issue to actual worker (isemail or node-email-verifier or whatever)

@MikeMcC399
Copy link

@DanielYang59

Thanks for letting me know. I don't know much about the internal working of markdown-link-check so not sure if I should propagate the issue to actual worker (isemail or node-email-verifier or whatever)

I'm not familiar with this in-depth, but It's probably an enhancement request for this repo. You can check yourself about the functionality of node-email-verifier, which looks like it only deals with a single e-mail address and not a complete mailto: link with multiple addresses and a subject field.

@smainil
Copy link

smainil commented Dec 6, 2024

the code of the email check is here https://github.com/tcort/link-check/blob/3263c3b65917375c209928ca2b1ad4102824da36/lib/proto/mailto.js#L8. It only checks the text between the mailto: and the ? character as a single email. It should try to split the string using the comma separator and loop on each single email found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants