Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping pre-commit from v3.12.2 to v3.13.6 breaks printing cause of errors #387

Open
vorburger opened this issue Dec 11, 2024 · 0 comments

Comments

@vorburger
Copy link
Contributor

In https://github.com/enola-dev/enola/pull/960/files I (originally, since changed) included bumping a markdown-link-check pre-commit from v3.12.2 to v3.13.6. This caused the following failure, which is quite confusing - note how it doesn't actually print (anymore) WHAT the problem is:

$ pre-commit run --all-files
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check that executables have shebangs.....................................Passed
check for merge conflicts................................................Passed
check that scripts with shebangs are executable..........................Passed
check for broken symlinks............................(no files to check)Skipped
check vcs permalinks.....................................................Passed
check yaml...............................................................Passed
detect destroyed symlinks................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
Insert license in comments...............................................Passed
Insert license in comments...............................................Passed
Insert license in comments...............................................Passed
Insert license in comments...............................................Passed
clang-format.............................................................Passed
Lint Protocol Buffer Files...............................................Passed
Google (or Palantir) Java Formatter......................................Passed
markdownlint-cli2........................................................Passed
Markdown Link Check......................................................Failed
- hook id: markdown-link-check
- exit code: 1
buildifier...............................................................Passed
buildifier-lint..........................................................Passed
prettier.................................................................Passed
csslint..................................................................Passed
yamllint.................................................................Passed
shellcheck...............................................................Passed
Validate GitHub Actions..............................(no files to check)Skipped
Validate GitHub Workflows................................................Passed
Validate Dependabot Config (v2)..........................................Passed
Validate Renovate Config.................................................Passed
Validate JSON Schema files...........................(no files to check)Skipped
Validate files with jsonschema.......................(no files to check)Skipped
Validate files with jsonschema.......................(no files to check)Skipped
Validate files with jsonschema...........................................Passed
Check .editorconfig rules................................................Passed

There is probably some way to run pre-commit to show more debugging type logs, which may be useful for this? Do you know how?

Let me know if it would be useful if I "dissected" the versions between v3.12.2 to v3.13.6 to narrow down for you starting with which version this started to happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant