Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-AMENDMENT_PATHWAY_STANDARDIZED #278

Open
ArthurChapman opened this issue Feb 8, 2024 · 17 comments
Open

TG2-AMENDMENT_PATHWAY_STANDARDIZED #278

ArthurChapman opened this issue Feb 8, 2024 · 17 comments
Labels
Amendment Conformance CORE TG2 CORE tests OTHER Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 VOCABULARY

Comments

@ArthurChapman
Copy link
Collaborator

ArthurChapman commented Feb 8, 2024

TestField Value
GUID f9205977-f145-44f5-8cb9-e3e2e35ce908
Label AMENDMENT_PATHWAY_STANDARDIZED
Description Propose an amendment to the value of dwc:pathway using the bdq:sourceAuthority.
TestType Amendment
Darwin Core Class dwc:Occurrence
Information Elements ActedUpon dwc:pathway
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:pathway is bdq:Empty; AMENDED the value of dwc:pathway if it can be unambiguously matched to a term in the bdq:sourceAuthority; otherwise NOT_AMENDED
Data Quality Dimension Conformance
Term-Actions PATHWAY_STANDARDIZED
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}
Specification Last Updated 2024-09-18
Examples [dwc:pathway="transportStowaway": Response.status=AMENDED, Response.result=dwc:pathway="transportStowaway", Response.comment="dwc:pathway found in the bdq:sourceAuthority"]
[dwc:pathway="escapeee": Response.status=NOT_AMENDED, Response.result="", Response.comment="dwc:pathway not found in the bdq:sourceAuthority"]
Source TG2
References
  • Darwin Core Maintenance Group (2021) Pathway Controlled Vocabulary List of Terms. Biodiversity Information Standards (TDWG). https://dwc.tdwg.org/pw/
  • Groom et al. (2019) Improving Darwin Core for research and management of alien species. Biodiversity Information Science and Services 3: e38084. https://doi.org/10.3897/biss.3.38084
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes For reference, synonyms for values of dwc:pathway can be found at https://registry.gbif.org/vocabulary/Pathway/concepts.
@ArthurChapman ArthurChapman added TG2 Amendment OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT NEEDS WORK Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Conformance Parameterized Test requires a parameter labels Feb 8, 2024
@ArthurChapman
Copy link
Collaborator Author

Should be made CORE - See comments under #268.

@Tasilee Tasilee added CORE TG2 CORE tests and removed Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. labels Feb 9, 2024
@Tasilee
Copy link
Collaborator

Tasilee commented Feb 9, 2024

I removed the Note re Supplementary.

@ymgan
Copy link
Collaborator

ymgan commented Feb 12, 2024

is this the sourceAuthority perhaps - https://dwc.tdwg.org/pw/ ?

@chicoreus
Copy link
Collaborator

Valuable, but not fitting the CORE use case as defined by TG3. Very likely applicable to regional checklist data. Almost certainly not populated in almost all occurrence data.

As with several other recently added related tests, needs a separate grouping to match a to be defined use case for checklist data.

@chicoreus chicoreus added Checklist Tests relevant to checklist data. and removed CORE TG2 CORE tests labels Feb 12, 2024
@ArthurChapman
Copy link
Collaborator Author

Thanks @ymgan I meant to have this link in the References but I'd not changed after cut and paste. Corrected now

@ArthurChapman ArthurChapman removed the Checklist Tests relevant to checklist data. label Feb 13, 2024
@ArthurChapman
Copy link
Collaborator Author

See my comment #285 (comment) under #285. I suggest that this test should be CORE, but should include a note that it is expected that most results would return a INTERNAL_PREREQUISITES_NOT_MET result.

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 19, 2024

If #285 and this test serve a specific community, it would fit Supplementary rather than CORE on the basis of "widely applicable"?

@ArthurChapman
Copy link
Collaborator Author

This (along with Degree of Establishment) has a major Use Case as set out in Groom et al. and is increasing being used in the Invasive Species community. Invasive Species are a big issue around the world and are one of the Key Issues in the Biodiversity Convention. So definitely "Widely applicable" These terms have not long been included in Darwin Core, but now that they are there is a large coordinated user community beginning to use them. This community is not specific as under the Convention on Biological Diversity, most countries and governments around the world are required to work on this issue. I would strongly push for CORE as I see no reason to exclude them as the test is well written and there are suitable Vocabularies and API.

@ArthurChapman
Copy link
Collaborator Author

The four tests (#277, #278, #268, #269) should be CORE (I have discussed this with Lee). Some reasons are

  • Invasive species are subject of the Convention on Biological Diversity Article 8(h) (https://www.cbd.int/idb/2009/about/cbd) and with a strong use case in the Cop 6 Decision last year VI/23 (https://www.cbd.int/decision/cop/default.shtml?id=7197)
  • These terms are recent additions to Darwin Core and are aspirational (we want all adding data follow the Standard)
  • There are good, well thought out vocabularies and APIs available
  • Apart from the CBD Use Case, there are good Use Case arguments given in Groom et al. (reference above)
  • There is no reason under our current criteria for excluding these tests from CORE

@chicoreus
Copy link
Collaborator

Source authority should be:

bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/]}

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 24, 2024

Thanks @chicoreus - Changing Source Authority from

bdq:sourceAuthority default = "Darwin Core pathway" {[https://dwc.tdwg.org/list/#dwc_pathway]} {dwc:pathway vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

to

bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/]}

@Tasilee
Copy link
Collaborator

Tasilee commented Mar 19, 2024

Should the Source Authority (API) be "https://api.gbif.org/v1/vocabularies/Pathway/concepts"?

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Changed Source Authority from

bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

to

bdq:sourceAuthority default = "GBIF Pathway Vocabulary" [https://api.gbif.org/v1/vocabularies/Pathway]} {"dwc:pathway vocabulary API" [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

@tucotuco
Copy link
Member

This was correct before the change. Darwin Core has the formal recommended vocabulary.

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Reverted Source Authority

@chicoreus
Copy link
Collaborator

See #275 (comment)

The GBIF API is only of partial help here, it does not provide the actual Controlled Values from the TDWG vocabulary, the values it has differ in case, implementations can use the GBIF API for its additional values, but need to align the case to match the actual Controlled Value from the TDWG vocabulary for the dwc: term values (GBIF API is sufficient for the dwciri term values).

@Tasilee
Copy link
Collaborator

Tasilee commented May 14, 2024

GBIF vocabulary has now been aligned with Darwin Core. Thanks @timrobertson100

chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Jul 27, 2024
…ng implementation for tdwg/bdq#278 AMENDMENT_PATHWAY_STANDARDIZED along with default method and unit test.
chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Aug 21, 2024
…#276 and tdwg/bdq#278 to recognized variants of controlled vocabulary terms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Amendment Conformance CORE TG2 CORE tests OTHER Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 VOCABULARY
Projects
None yet
Development

No branches or pull requests

5 participants