Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#229 [feat] 버전 조회하기 #230

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

hyeonjeongs
Copy link
Contributor

⭐ Related Issue

📌 Work description

  • 현재 강제 업데이트 버전 확인

✔️ Questioon & PR point

@hyeonjeongs hyeonjeongs added the feat 새로운 기능 구현 label Oct 23, 2023
@hyeonjeongs hyeonjeongs self-assigned this Oct 23, 2023
Copy link
Member

@yeseul106 yeseul106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ! 리뷰 남겼어요 !


const router: Router = Router();

//* 닉네임 중복 검사 POST /user/duplicate
router.post("/duplicate", userController.postDuplicateNickname);
//* 유저 업데이트 버전 확인하기 GET /user/version
router.get("/version", auth, userController.getUserVersion)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금 구현되고 있는 api 부터는 엔드포인트 버저닝을 하는게 좋을 것 같아서 ! 엔드포인트 매핑하는거 /v1/version으로 수정해주시면 감사하겠습니다 !

@hyeonjeongs hyeonjeongs changed the title #229 [fix] test fix #229 [feat] 버전 조회하기 Oct 23, 2023
@hyeonjeongs hyeonjeongs merged commit c341f70 into develop Oct 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능 구현 현정🐸
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 업데이트 버전 확인
2 participants