Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): 修正 Database 上 get 方法对不含 where 字段 query 的处理 #94

Closed
wants to merge 1 commit into from
Closed

fix(storage): 修正 Database 上 get 方法对不含 where 字段 query 的处理 #94

wants to merge 1 commit into from

Conversation

chuan6
Copy link
Contributor

@chuan6 chuan6 commented Jul 14, 2017

...并在 concat selector 时进行的查询信息等价比较上，妥善处理
predicateProvider 为空而导致没有 toString 方法可调用，throw 的情况。

...resolves #93

@chuan6
fix(storage): 修正 Database 上 get 方法对不含 where 字段 query 的处理
7c2b608 
...并在 concat selector 时进行的查询信息等价比较上，妥善处理
predicateProvider 为空而导致没有 toString 方法可调用，throw 的情况。

...resolves #93
@chuan6 chuan6 self-assigned this Jul 14, 2017
@chuan6 chuan6 requested a review from Saviio July 14, 2017 10:49
@Brooooooklyn
Copy link
Contributor

please pull request to https://github.com/reactivedb/core

@chuan6
Copy link
Contributor Author

chuan6 commented Jul 18, 2017

@Brooooooklyn 好 👌

@chuan6
Copy link
Contributor Author

chuan6 commented Jul 18, 2017

@Brooooooklyn done

@chuan6 chuan6 closed this Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saviio Saviio Awaiting requested review from Saviio

Assignees

@chuan6 chuan6

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selector concat 时，需要妥善处理 where 字段为空的 query 的等价验证
2 participants
@chuan6 @Brooooooklyn