Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased commits are not supported #15

Open
gravis opened this issue Oct 10, 2012 · 1 comment
Open

Rebased commits are not supported #15

gravis opened this issue Oct 10, 2012 · 1 comment
Labels

Comments

@gravis
Copy link
Member

gravis commented Oct 10, 2012

Due the way the worker is currently working, rebased commits may not be tested, and remain "pending" after running the test-suite.
A refactor of the worker and how builds are handled is needed

@comboy
Copy link
Contributor

comboy commented Oct 19, 2012

You can't actually rebase something in the upstream until you do force push. If you rebase locally moci does not even know. So that does not seem to be a common scenario.

Anyway, worker seems to have nothing to do with it. It should be probably in VCS:Git, but as far as I remember, if you rebase commits hash will change, so moci should jest see these as new commits (IIRC).

What could be left pending, are these orphaned commits if test suites for these were not run before rebase was pushed. And that seems ok, nobody cares about them, we could just make them not displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants