Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] allow hide() to set animate prop #242

Open
henryyuuu opened this issue Jul 11, 2024 · 2 comments
Open

[FEAT] allow hide() to set animate prop #242

henryyuuu opened this issue Jul 11, 2024 · 2 comments
Assignees

Comments

@henryyuuu
Copy link

henryyuuu commented Jul 11, 2024

How to reproduce:
step 1. pane.hide()
step 2. pane.present({animate: false})

It seems that the pane will present with animate even i call present with animate: false.
Is this the correct behavior? Or how can i present a pane without animate when it's hidden?

thanks

@roman-rr roman-rr self-assigned this Jul 11, 2024
@roman-rr
Copy link
Collaborator

Thank you @henryyuuu
You are right! This is probably because most useful case is

pane.present({animate: false});

pane.destroy({animate: false});

pane.present({animate: false});

Hide function used with transition.

Does animate: false will fix your needs, or you need to using hide() function instead of present/destroy ?

@henryyuuu
Copy link
Author

hi @roman-rr,
thanks for fast reply, i just want to make sure if this is a bug or there's other public method that i missed.
i will use other method instead of hide in my case. Thanks very much.

@roman-rr roman-rr changed the title [BUG] cannot present pane without animate if the pane is hidden [FEAT] allow hide() to set animate prop Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants