Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PAC-96 image override option #181

Open
pathmissing opened this issue May 22, 2020 · 0 comments
Open

Refactor PAC-96 image override option #181

pathmissing opened this issue May 22, 2020 · 0 comments
Labels
refactoring Things that have to be refactored

Comments

@pathmissing
Copy link
Member

pathmissing commented May 22, 2020 •
edited
Loading

PAC-96 introduced a new option which allows overriding already existing images. In order to stay backwards compabile, new methods and attributes were made private in
src/Subjects/FileUploadTrait.php. These should be either public or protected.

Additionally, a new constant OVERRIDE_IMAGES should be introduced in the ConfigurationKeys utility class for components using the new option:

  • techdivision/import-attribute
    • src/Subjects/OptionSubject.php
    • src/Utils/ConfigurationKeys.php
  • techdivision/import-category
    • src/Subjects/BunchSubject.php
    • src/Utils/ConfigurationKeys.php
  • techdivision/import-product
    • src/Subjects/BunchSubject.php
    • src/Utils/ConfigurationKeys.php

The necessary changes are highligted as "TODOs" in the corresponding files.
@pathmissing pathmissing added the refactoring Things that have to be refactored label May 22, 2020
@pathmissing pathmissing self-assigned this Aug 19, 2020
This was referenced Aug 19, 2020
Merged
Merged
Merged
Merged
@pathmissing pathmissing removed their assignment Aug 24, 2020
Mardl added a commit that referenced this issue Mar 26, 2021
@Mardl
* Fixes bug to add more listener when event name has already some lis…
d07a45b 
…tener

* Add #PAC-96: Define new constands for FileUploadConfiguration
    * #181
Mardl added a commit to techdivision/import-attribute that referenced this issue Mar 26, 2021
@Mardl
* PAC-96: Use new constands for FileUploadConfiguration
6516e22 
    * techdivision/import#181
* PAC-361: Don't check file system if copy-images defined as false
    * techdivision/import-cli-simple#262
Mardl added a commit to techdivision/import-category that referenced this issue Mar 26, 2021
@Mardl
* PAC-96: Use new constands for FileUploadConfiguration
7d663ff 
    * techdivision/import#181
* PAC-361: Don't check file system if copy-images defined as false
    * techdivision/import-cli-simple#262
Mardl added a commit to techdivision/import-product that referenced this issue Mar 26, 2021
@Mardl
* PAC-96: Use new constands for FileUploadConfiguration
e531346 
    * techdivision/import#181
* PAC-361: Don't check file system if copy-images defined as false
    * techdivision/import-cli-simple#262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Things that have to be refactored
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pathmissing