From 79bd5878e81aace896b0723e77defd80b5346f04 Mon Sep 17 00:00:00 2001
From: Mark Johnson <739719+virgofx@users.noreply.github.com>
Date: Sat, 26 Oct 2024 15:14:23 -0700
Subject: [PATCH] fix: ensure regex character classes aren't used for single
 char (#87)

---
 src/pull-request.ts | 2 +-
 src/wiki.ts         | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/pull-request.ts b/src/pull-request.ts
index e42c668..0225768 100644
--- a/src/pull-request.ts
+++ b/src/pull-request.ts
@@ -214,7 +214,7 @@ export async function getPullRequestCommits(): Promise<CommitDetails[]> {
 export async function addReleasePlanComment(
   terraformChangedModules: TerraformChangedModule[],
   terraformModuleNamesToRemove: string[],
-  wikiStatus: { status: WikiStatus; errorMessage?: string | undefined },
+  wikiStatus: { status: WikiStatus; errorMessage?: string },
 ): Promise<void> {
   console.time('Elapsed time commenting on pull request');
   startGroup('Adding pull request release plan comment');
diff --git a/src/wiki.ts b/src/wiki.ts
index 374fa27..c8f5c35 100644
--- a/src/wiki.ts
+++ b/src/wiki.ts
@@ -271,11 +271,11 @@ async function updateWikiSidebar(terraformModules: TerraformModule[]): Promise<v
         const heading = headingMatch[1].trim();
 
         // Convert heading into a valid ID string (keep only [a-zA-Z0-9-_]) But we need spaces to go to a '-'
-        const idString = heading.replace(/[ ]+/g, '-').replace(/[^a-zA-Z0-9-_]/g, '');
+        const idString = heading.replace(/ +/g, '-').replace(/[^a-zA-Z0-9-_]/g, '');
 
         // Append the entry to changelogEntries
         changelogEntries.push(
-          `            <li><a href="${baselink}#${idString}">${heading.replace(/[`]/g, '')}</a></li>`,
+          `            <li><a href="${baselink}#${idString}">${heading.replace(/`/g, '')}</a></li>`,
         );
       }