You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I went to init all my existing 33 modules at v1.0.0, I hit an issue where only 30 Github Releases were created. My PR had 33 files changed to trigger terraform-modules-releaser on each one, but in the "Finding all Terraform modules with corresponding changes" step, it said:
Hey @sorliem - Thank you for catching this and for the kind words about the project!
While I thought I had pagination implemented for most API calls, I clearly missed this one for pull request files.
As a temporary workaround: any subsequent commit should trigger the releaser on the remaining 3 modules that weren't processed in the first run. Could you let me know if this works for your case?
I'll prioritize adding proper pagination for the PR files endpoint to handle repositories with >30 module changes. I'll ping you once I've released a new version with the fix.
Thanks again for bringing this to our attention - these are exactly the kind of edge cases we need to catch to make the tool more robust! 🙌
Hello - first, thanks for making this!
When I went to init all my existing 33 modules at v1.0.0, I hit an issue where only 30 Github Releases were created. My PR had 33 files changed to trigger terraform-modules-releaser on each one, but in the "Finding all Terraform modules with corresponding changes" step, it said:
Looking at the Github api it looks like 30 is the default: https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#list-pull-requests-files
This is a bit of an edge case but paging would be helpful here. If I get some time I can take a crack at a fix.
The text was updated successfully, but these errors were encountered: