You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be great to be able to change the format of the source generated in the wiki to use the typical SSH format.
eg: [email protected]:techpivot/terraform-module-releaser.git rather than git::https://github.com/techpivot/terraform-module-releaser.git
I am about to submit a PR that adds a quick and dirty implementation, just to give an idea. I am not a TypeScript guy or overly familiar with the codebase so this isn't meant to be an all encompassing thing, but hopefully a good place to start if you agree with this issue.
Hi @LiamBull Great suggestion and I think it makes perfect sense. I just quickly browsed the PR and it's pretty close to what I'd do. I believe the only other thing I would do is add some testing for it to test both sides as I was able to get 100% test coverage. I'm happy to merge yours (unreleased) and then add the tests on top if that works? Alternatively, if you wanted to try and get some tests working I'm happy to let you drive this effort?
Edit: Appears I may have a token issue in the latest CI somewhere so I'll need to work on a few things somewhere first!
It would be great to be able to change the format of the
source
generated in the wiki to use the typical SSH format.eg:
[email protected]:techpivot/terraform-module-releaser.git
rather thangit::https://github.com/techpivot/terraform-module-releaser.git
I am about to submit a PR that adds a quick and dirty implementation, just to give an idea. I am not a TypeScript guy or overly familiar with the codebase so this isn't meant to be an all encompassing thing, but hopefully a good place to start if you agree with this issue.
PR: #137
The text was updated successfully, but these errors were encountered: