-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the insert performance in the server #75
Comments
working on this |
Great, do you wanna collaborate on this? Seems like a good issue to work on. |
Sure @bhagatvansh! Created a draft PR of the solution that I thought of, let me know what you think |
Sure, did you compare the memory performance? |
@bhagatvansh Hadn't done it before, but checked just now, here's what I found, One weird thing is, for small batch size when we were creating multiple slices with I have added a test files, you can run the tests on your end once to verify. |
We are performing way too many allocations in the
StartWritingLogs
function in the server log writer file. We need to optimize that so that high bursts of incoming log traffic could be ingested. Things we can try:BarkLogDao.InsertBatch
function to theStartWritingLogs
function - that should avoid the memory copy required for making the function call and the memory allocations happening inside theInsertBatch
function.The text was updated successfully, but these errors were encountered: