-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Logos on Error pages #10
Comments
@redoPop so are these live now? |
Not in the way you mean, no. This issue was closed automatically via a "resolves #XXX" commit message when I pushed some old local changes upstream last night. Sorry about that – usually I try to leave something like this open until it's been reviewed. A new This is something that's been a slight thorn with this repo: because it exists separately as a dependency that can be consumed by Roadrunner and other applications, it's difficult for you to review its changes until they enter a production environment. I need to set up a simple "staging" site (perhaps an S3 bucket) where you can review and approve commits. |
Thanks for the 411, @redoPop ! |
Okidoki. An Error Pages staging / preview site has at long last been created: https://error-pages.staging.ted.com/ How's that logo looking? |
Looking good to me, @redoPop! I shared with Mike Femia to confirm. I love that staging site. Should we TEDify it at all? |
@redoPop Femia approves. |
Excellent! Happy to give the staging site a more polished index page if it has internal value, but just in case you have public exposure in mind: I'd prefer not to do that – there's too much risk of creating false flags once we build alerting into our 50X responses (#9). I really just set the staging area up as a way of simplifying dev↔UX feedback/collaboration while we work on weedsier issues like #11. I figure we may need a few rounds of changes before we get that right, and it's easier to do that if you can see the actual error pages! |
@redoPop — totally get it. was just thinking something to feel TED: https://ted.invisionapp.com/share/SNBLHYT3X#/232425572_Desktop_HD |
We got a note from Mike Femia that the logos were incorrect—I suspect it was the shape of the E. Updated logos in SVG format can be found here
The text was updated successfully, but these errors were encountered: