Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Logos on Error pages #10

Closed
mmcwatters opened this issue Mar 6, 2017 · 8 comments
Closed

Replace Logos on Error pages #10

mmcwatters opened this issue Mar 6, 2017 · 8 comments

Comments

@mmcwatters
Copy link

We got a note from Mike Femia that the logos were incorrect—I suspect it was the shape of the E. Updated logos in SVG format can be found here

@mmcwatters
Copy link
Author

@redoPop so are these live now?

@redoPop
Copy link
Contributor

redoPop commented Mar 29, 2017

Not in the way you mean, no. This issue was closed automatically via a "resolves #XXX" commit message when I pushed some old local changes upstream last night. Sorry about that – usually I try to leave something like this open until it's been reviewed.

A new error_pages release has been cut (2.0.2), so from the perspective of this repository the changes have entered production use, but we've not made any Roadrunner deployments since last night, so ted.com doesn't reflect that. (We try not to make production deployments outside of work hours.)

This is something that's been a slight thorn with this repo: because it exists separately as a dependency that can be consumed by Roadrunner and other applications, it's difficult for you to review its changes until they enter a production environment. I need to set up a simple "staging" site (perhaps an S3 bucket) where you can review and approve commits.

@redoPop redoPop reopened this Mar 29, 2017
@mmcwatters
Copy link
Author

Thanks for the 411, @redoPop !

@redoPop
Copy link
Contributor

redoPop commented May 2, 2017

Okidoki. An Error Pages staging / preview site has at long last been created:

https://error-pages.staging.ted.com/

How's that logo looking?

@mmcwatters
Copy link
Author

Looking good to me, @redoPop! I shared with Mike Femia to confirm. I love that staging site. Should we TEDify it at all?

@mmcwatters
Copy link
Author

@redoPop Femia approves.

@redoPop
Copy link
Contributor

redoPop commented May 5, 2017

Excellent!

Happy to give the staging site a more polished index page if it has internal value, but just in case you have public exposure in mind: I'd prefer not to do that – there's too much risk of creating false flags once we build alerting into our 50X responses (#9).

I really just set the staging area up as a way of simplifying dev↔UX feedback/collaboration while we work on weedsier issues like #11. I figure we may need a few rounds of changes before we get that right, and it's easier to do that if you can see the actual error pages!

@redoPop redoPop closed this as completed May 5, 2017
@mmcwatters
Copy link
Author

@redoPop — totally get it. was just thinking something to feel TED: https://ted.invisionapp.com/share/SNBLHYT3X#/232425572_Desktop_HD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants