From d9f002666574b83c301d30e0a6f4ca27e9380587 Mon Sep 17 00:00:00 2001
From: Joe Stuart <jstuart@redhat.com>
Date: Mon, 7 Aug 2023 14:28:02 -0500
Subject: [PATCH] create build type constants

---
 .../internal/build_definitions/build_definitions.go       | 6 ++++++
 .../slsa/v2alpha2/internal/pipelinerun/pipelinerun.go     | 8 +++-----
 .../formats/slsa/v2alpha2/internal/taskrun/taskrun.go     | 4 ++--
 3 files changed, 11 insertions(+), 7 deletions(-)
 create mode 100644 pkg/chains/formats/slsa/v2alpha2/internal/build_definitions/build_definitions.go

diff --git a/pkg/chains/formats/slsa/v2alpha2/internal/build_definitions/build_definitions.go b/pkg/chains/formats/slsa/v2alpha2/internal/build_definitions/build_definitions.go
new file mode 100644
index 0000000000..02766e1f46
--- /dev/null
+++ b/pkg/chains/formats/slsa/v2alpha2/internal/build_definitions/build_definitions.go
@@ -0,0 +1,6 @@
+package builddefinitions
+
+const (
+	SlsaBuildType   = "https://tekton.dev/chains/v2/slsa"
+	TektonBuildType = ""
+)
diff --git a/pkg/chains/formats/slsa/v2alpha2/internal/pipelinerun/pipelinerun.go b/pkg/chains/formats/slsa/v2alpha2/internal/pipelinerun/pipelinerun.go
index 46d1a16f63..0b2b6d998e 100644
--- a/pkg/chains/formats/slsa/v2alpha2/internal/pipelinerun/pipelinerun.go
+++ b/pkg/chains/formats/slsa/v2alpha2/internal/pipelinerun/pipelinerun.go
@@ -28,9 +28,7 @@ import (
 const (
 	pipelineRunResults = "pipelineRunResults/%s"
 	// JsonMediaType is the media type of json encoded content used in resource descriptors
-	JsonMediaType   = "application/json"
-	slsaBuildType   = "https://tekton.dev/chains/v2/slsa"
-	tektonBuildType = ""
+	JsonMediaType = "application/json"
 )
 
 // GenerateAttestation generates a provenance statement with SLSA v1.0 predicate for a pipeline run.
@@ -110,14 +108,14 @@ func byproducts(pro *objects.PipelineRunObject) ([]slsa.ResourceDescriptor, erro
 
 func getBuildDefinition(buildType string, pro *objects.PipelineRunObject) (builddefinitions.PipelineBuildType, error) {
 	switch buildType {
-	case slsaBuildType:
+	case builddefinitions.SlsaBuildType:
 		return builddefinitions.PipelineBuildType{
 			BuildType:                buildType,
 			Pro:                      pro,
 			InternalParameters:       builddefinitions.SLSAPipelineInternalParameters,
 			AddTaskDescriptorContent: builddefinitions.AddSLSATaskDescriptor,
 		}, nil
-	case tektonBuildType:
+	case builddefinitions.TektonBuildType:
 		return builddefinitions.PipelineBuildType{
 			BuildType:                buildType,
 			Pro:                      pro,
diff --git a/pkg/chains/formats/slsa/v2alpha2/internal/taskrun/taskrun.go b/pkg/chains/formats/slsa/v2alpha2/internal/taskrun/taskrun.go
index ba4954b6ec..2f5f05fe25 100644
--- a/pkg/chains/formats/slsa/v2alpha2/internal/taskrun/taskrun.go
+++ b/pkg/chains/formats/slsa/v2alpha2/internal/taskrun/taskrun.go
@@ -104,13 +104,13 @@ func byproducts(tro *objects.TaskRunObject) ([]slsa.ResourceDescriptor, error) {
 
 func getBuildDefinition(buildType string, tro *objects.TaskRunObject) (builddefinitions.TaskBuildType, error) {
 	switch buildType {
-	case "https://tekton.dev/chains/v2/slsa":
+	case builddefinitions.SlsaBuildType:
 		return builddefinitions.TaskBuildType{
 			BuildType:          buildType,
 			Tro:                tro,
 			InternalParameters: builddefinitions.SLSATaskInternalParameters,
 		}, nil
-	case "tekton-build-type":
+	case builddefinitions.TektonBuildType:
 		return builddefinitions.TaskBuildType{
 			BuildType:          buildType,
 			Tro:                tro,