From 3fa1862b650c25b8e69c18aadb6658450c86d54b Mon Sep 17 00:00:00 2001 From: Emil Thies Date: Sun, 15 Dec 2024 17:09:42 +0100 Subject: [PATCH] Use PhoneLib 8.13.52 (adapting also new meta data bug of DE 176 range) and prepare release (#92) Use PhoneLib 8.13.52 (adapting also new meta data bug of DE 176 range) and prepare release Meta Data bug reported: https://issuetracker.google.com/issues/384186540 --- REPORTED_ISSUES.md | 3 ++ pom.xml | 6 ++-- .../PhoneNumberUtil/IsValidNumberTest.groovy | 36 +++++++++---------- 3 files changed, 24 insertions(+), 21 deletions(-) diff --git a/REPORTED_ISSUES.md b/REPORTED_ISSUES.md index 6560aeb..0e62aef 100644 --- a/REPORTED_ISSUES.md +++ b/REPORTED_ISSUES.md @@ -58,3 +58,6 @@ Google stated it is aware and will bring changes after investigation that users Google [fixed](https://github.com/google/libphonenumber/pull/3671/files#diff-5061a7d3c54ba589aacce00dcee1ce92e098c40034749bcae4c8a4780bb40233) it with [8.13.48](https://github.com/google/libphonenumber/pull/3671) on 16.10.2024 While normal mobile numbers are now aligend, voicemail numbers length is still problematic (BUG needs to be reported!). + +### 2024-12-14 - [Metadata Update of 8.13.52 for DE mobile 176 range is invalid](https://issuetracker.google.com/issues/384186540) +While Google had corrected mobile 17x range with prior feedback, they introduced an inconsistency with the last DE meta data update. \ No newline at end of file diff --git a/pom.xml b/pom.xml index 21588dd..77a9303 100644 --- a/pom.xml +++ b/pom.xml @@ -23,7 +23,7 @@ normalizer Phonenumber Normalizer Library to work with phonenumbers, especially to fix googles PhoneLib ignoring German Landline specifics. - 1.3.5-SNAPSHOT + 1.3.5 jar https://github.com/telekom/phonenumber-normalizer @@ -86,7 +86,7 @@ com.googlecode.libphonenumber libphonenumber - 8.13.51 + 8.13.52 @@ -150,7 +150,7 @@ com.googlecode.libphonenumber geocoder - 2.245 + 2.246 test diff --git a/src/test/groovy/de/telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberUtil/IsValidNumberTest.groovy b/src/test/groovy/de/telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberUtil/IsValidNumberTest.groovy index 24d2c96..5e1c59b 100644 --- a/src/test/groovy/de/telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberUtil/IsValidNumberTest.groovy +++ b/src/test/groovy/de/telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberUtil/IsValidNumberTest.groovy @@ -1816,25 +1816,25 @@ class IsValidNumberTest extends Specification { // // 0176 // - "01760" | "DE" | [false, false, false, false, false, false, false, false] - "01761" | "DE" | [false, false, false, false, false, false, false, false] - "01762" | "DE" | [false, false, false, false, false, false, false, false] - "017630" | "DE" | [false, false, false, false, false, false, false, false] - "017631" | "DE" | [false, false, false, false, false, false, false, false] - "017632" | "DE" | [false, false, false, false, false, false, false, false] + "01760" | "DE" | [false, true, false, false, false, true, false, false] + "01761" | "DE" | [false, true, false, false, false, true, false, false] + "01762" | "DE" | [false, true, false, false, false, true, false, false] + "017630" | "DE" | [false, true, false, false, false, true, false, false] + "017631" | "DE" | [false, true, false, false, false, true, false, false] + "017632" | "DE" | [false, true, false, false, false, true, false, false] // 017633 is reserved for voicemail - see tests below - "017634" | "DE" | [false, false, false, false, false, false, false, false] - "017635" | "DE" | [false, false, false, false, false, false, false, false] - "017636" | "DE" | [false, false, false, false, false, false, false, false] - "017637" | "DE" | [false, false, false, false, false, false, false, false] - "017638" | "DE" | [false, false, false, false, false, false, false, false] - "017639" | "DE" | [false, false, false, false, false, false, false, false] - "01764" | "DE" | [false, false, false, false, false, false, false, false] - "01765" | "DE" | [false, false, false, false, false, false, false, false] - "01766" | "DE" | [false, false, false, false, false, false, false, false] - "01767" | "DE" | [false, false, false, false, false, false, false, false] - "01768" | "DE" | [false, false, false, false, false, false, false, false] - "01769" | "DE" | [false, false, false, false, false, false, false, false] + "017634" | "DE" | [false, true, false, false, false, true, false, false] + "017635" | "DE" | [false, true, false, false, false, true, false, false] + "017636" | "DE" | [false, true, false, false, false, true, false, false] + "017637" | "DE" | [false, true, false, false, false, true, false, false] + "017638" | "DE" | [false, true, false, false, false, true, false, false] + "017639" | "DE" | [false, true, false, false, false, true, false, false] + "01764" | "DE" | [false, true, false, false, false, true, false, false] + "01765" | "DE" | [false, true, false, false, false, true, false, false] + "01766" | "DE" | [false, true, false, false, false, true, false, false] + "01767" | "DE" | [false, true, false, false, false, true, false, false] + "01768" | "DE" | [false, true, false, false, false, true, false, false] + "01769" | "DE" | [false, true, false, false, false, true, false, false] // // 0177