From 1b4a771c40eea2f126238743c9f74e867b9c292f Mon Sep 17 00:00:00 2001 From: Arturo Castillo Delgado Date: Wed, 13 Sep 2023 11:10:45 +0200 Subject: [PATCH 1/4] chore: update CODEOWNERS file (#2124) --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 63024c16ad..ecdd717c39 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -5,4 +5,4 @@ # For more details, read the following article on GitHub: https://help.github.com/articles/about-codeowners/. # These are the default owners for the whole content of this repository. The default owners are automatically added as reviewers when you open a pull request, unless different owners are specified in the file. -* @acstll @nowseemee +* @maomaoZH @acstll @felix-ico From 5423cb80520f93aae52eab4ff6a5477dcd072f09 Mon Sep 17 00:00:00 2001 From: Arturo Castillo Delgado Date: Wed, 13 Sep 2023 16:21:37 +0200 Subject: [PATCH 2/4] fix(radio-button): ensure change event is emitted when clicking input-label gap (#2123) --- .../components/src/components/radio-button/radio-button.css | 5 +++-- .../radio-button-group/RadioButtonGroup.stories.mdx | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/components/src/components/radio-button/radio-button.css b/packages/components/src/components/radio-button/radio-button.css index 8f0a6396f8..c939e3fbc0 100644 --- a/packages/components/src/components/radio-button/radio-button.css +++ b/packages/components/src/components/radio-button/radio-button.css @@ -40,12 +40,12 @@ scale-radio-button { --transition-label: var(--transition); --font-weight-label: var(--telekom-typography-font-weight-medium); --color-label: var(--color-text); + --spacing-label: var(--telekom-spacing-composition-space-04); /*control*/ --width-control: var(--telekom-spacing-composition-space-07); --height-control: var(--telekom-spacing-composition-space-07); --transition-control: var(--transition); - --spacing-control: 0 var(--telekom-spacing-composition-space-04) 0 0; --background-color-control: var(--telekom-color-ui-base); --border-control: var(--telekom-spacing-composition-space-01) solid var(--telekom-color-ui-border-standard); @@ -114,6 +114,7 @@ scale-icon-alert-error { font-weight: var(--font-weight-label); cursor: pointer; line-height: var(--telekom-typography-line-spacing-standard); + padding-left: var(--spacing-label); } .radio-button input { width: var(--width-control); @@ -123,7 +124,7 @@ scale-icon-alert-error { -webkit-appearance: none; background-color: var(--telekom-color-ui-state-fill-standard); border: var(--border-control); - margin: var(--spacing-control); + margin: 0; cursor: pointer; } diff --git a/packages/storybook-vue/stories/components/radio-button-group/RadioButtonGroup.stories.mdx b/packages/storybook-vue/stories/components/radio-button-group/RadioButtonGroup.stories.mdx index 2909e317da..e7d12e2a55 100644 --- a/packages/storybook-vue/stories/components/radio-button-group/RadioButtonGroup.stories.mdx +++ b/packages/storybook-vue/stories/components/radio-button-group/RadioButtonGroup.stories.mdx @@ -164,12 +164,12 @@ scale-radio-button { --transition-label: var(--transition); --font-weight-label: var(--telekom-typography-font-weight-medium); --color-label: var(--color-text); + --spacing-label: var(--telekom-spacing-composition-space-04); /*control*/ --width-control: var(--telekom-spacing-composition-space-07); --height-control: var(--telekom-spacing-composition-space-07); --transition-control: var(--transition); - --spacing-control: 0 var(--telekom-spacing-composition-space-04) 0 0; --background-color-control: var(--telekom-color-ui-base); --border-control: var(--telekom-spacing-composition-space-01) solid var(--telekom-color-ui-border-standard); From 053b10d4e75616059a889b6e1d26012645eda97d Mon Sep 17 00:00:00 2001 From: Maomao Date: Wed, 13 Sep 2023 16:30:51 +0200 Subject: [PATCH 3/4] feat(data-grid): enable localization for flyout menu (#1411) * fix: add localization to flyout menu of data grid * chore: update readme of data-grid --------- Co-authored-by: Maomao Meyer-Zhang --- .../src/components/data-grid/data-grid.tsx | 16 ++++++-- .../src/components/data-grid/readme.md | 37 ++++++++++--------- .../components/data-grid/DataGrid.stories.mdx | 12 ++++++ 3 files changed, 43 insertions(+), 22 deletions(-) diff --git a/packages/components/src/components/data-grid/data-grid.tsx b/packages/components/src/components/data-grid/data-grid.tsx index 01555e2846..7a09e24ac1 100644 --- a/packages/components/src/components/data-grid/data-grid.tsx +++ b/packages/components/src/components/data-grid/data-grid.tsx @@ -107,7 +107,15 @@ export class DataGrid { @Prop() styles: any; /** (optional) Set to false to hide table, used for nested tables to re-render upon toggle */ @Prop() visible?: boolean = true; - + /** + * (optional) set localization for sort, toggle and select/deselect table + * Default is English. + */ + @Prop() localization?: { + sortBy: string; + toggle: string; + select: string; + }; /* 4. Events (alphabetical) */ /** Event triggered every time the editable cells are changed, updating the original rows data */ @Event({ eventName: 'scale-edit' }) @@ -767,7 +775,7 @@ export class DataGrid { onClick={this.handleMenuListClick} > - Sort By + {this.localization?.sortBy || 'Sort By'} {this.fields.map( ( @@ -819,7 +827,7 @@ export class DataGrid { onClick={this.handleMenuListClick} > - Toggle Visibility + {this.localization?.toggle || 'Toggle Visibility'} - Select / Deselect All + {this.localization?.select || 'Select / Deselect All'} )} diff --git a/packages/components/src/components/data-grid/readme.md b/packages/components/src/components/data-grid/readme.md index 2a319f6b66..8347285c54 100644 --- a/packages/components/src/components/data-grid/readme.md +++ b/packages/components/src/components/data-grid/readme.md @@ -5,24 +5,25 @@ ## Properties -| Property | Attribute | Description | Type | Default | -| ---------------- | ----------------- | -------------------------------------------------------------------------------------------- | ---------- | ----------- | -| `fields` | `fields` | Input fields config array | `any` | `undefined` | -| `freezeHeader` | `freeze-header` | (optional) Freeze header row from scrolling | `boolean` | `false` | -| `heading` | `heading` | (optional) Heading string | `string` | `''` | -| `height` | `height` | (optional) Set static table height, by default will auto-resize | `string` | `undefined` | -| `hideBorder` | `hide-border` | (optional) Set to true to remove border | `boolean` | `false` | -| `hideHeader` | `hide-header` | (optional) Set to true to hide header row | `boolean` | `false` | -| `hideInfo` | `hide-info` | (optional) Set to true to remove info footer block including pagination and selection status | `boolean` | `false` | -| `hideMenu` | `hide-menu` | (optional) Set to true to hide settings menu | `boolean` | `false` | -| `numbered` | `numbered` | (optional) Set to true to add numbers column | `boolean` | `false` | -| `pageSize` | `page-size` | (optional) Set number of rows to display per pagination page | `number` | `Infinity` | -| `rows` | `rows` | Input data array | `any` | `undefined` | -| `selectable` | `selectable` | (optional) Set to true to add selection column | `boolean` | `false` | -| `selection` | -- | Read-only selection array - populated with raw data from selected rows | `string[]` | `[]` | -| `shadeAlternate` | `shade-alternate` | (optional) Shade every second row darker | `boolean` | `true` | -| `styles` | `styles` | (optional) Injected css styles | `any` | `undefined` | -| `visible` | `visible` | (optional) Set to false to hide table, used for nested tables to re-render upon toggle | `boolean` | `true` | +| Property | Attribute | Description | Type | Default | +| ---------------- | ----------------- | -------------------------------------------------------------------------------------------- | ----------------------------------------------------- | ----------- | +| `fields` | `fields` | Input fields config array | `any` | `undefined` | +| `freezeHeader` | `freeze-header` | (optional) Freeze header row from scrolling | `boolean` | `false` | +| `heading` | `heading` | (optional) Heading string | `string` | `''` | +| `height` | `height` | (optional) Set static table height, by default will auto-resize | `string` | `undefined` | +| `hideBorder` | `hide-border` | (optional) Set to true to remove border | `boolean` | `false` | +| `hideHeader` | `hide-header` | (optional) Set to true to hide header row | `boolean` | `false` | +| `hideInfo` | `hide-info` | (optional) Set to true to remove info footer block including pagination and selection status | `boolean` | `false` | +| `hideMenu` | `hide-menu` | (optional) Set to true to hide settings menu | `boolean` | `false` | +| `localization` | -- | (optional) set localization for sort, toggle and select/deselect table Default is English. | `{ sortBy: string; toggle: string; select: string; }` | `undefined` | +| `numbered` | `numbered` | (optional) Set to true to add numbers column | `boolean` | `false` | +| `pageSize` | `page-size` | (optional) Set number of rows to display per pagination page | `number` | `Infinity` | +| `rows` | `rows` | Input data array | `any` | `undefined` | +| `selectable` | `selectable` | (optional) Set to true to add selection column | `boolean` | `false` | +| `selection` | -- | Read-only selection array - populated with raw data from selected rows | `string[]` | `[]` | +| `shadeAlternate` | `shade-alternate` | (optional) Shade every second row darker | `boolean` | `true` | +| `styles` | `styles` | (optional) Injected css styles | `any` | `undefined` | +| `visible` | `visible` | (optional) Set to false to hide table, used for nested tables to re-render upon toggle | `boolean` | `true` | ## Events diff --git a/packages/storybook-vue/stories/components/data-grid/DataGrid.stories.mdx b/packages/storybook-vue/stories/components/data-grid/DataGrid.stories.mdx index ed5d9d230e..83fb575a9f 100644 --- a/packages/storybook-vue/stories/components/data-grid/DataGrid.stories.mdx +++ b/packages/storybook-vue/stories/components/data-grid/DataGrid.stories.mdx @@ -99,6 +99,13 @@ import ScaleDataGrid from './ScaleDataGrid.vue'; description: `(optional) Set to true to add selection column`, control: { type: null }, }, + localization: { + table: { + type: { summary: 'object' }, + }, + description: `(optional) localization object for sort by, toogle visibility and select/deselect all. The default value is English`, + control: { type: null }, + }, shadeAlternate: { table: { type: { summary: 'boolean' }, @@ -228,6 +235,11 @@ export const Template = (args, {}) => ({ [4, 'Heidi', '3:15'], [5, 'Muhammad', '21:45'], ]; + dataGrid.localization = { + sortBy: 'Sort By', + toggle: 'Toogle Visibility', + select: 'Select / Deselect All' + } } `} From 442c15e7e30705ac56ccc5d7c4752d47941dc080 Mon Sep 17 00:00:00 2001 From: Arturo Date: Wed, 13 Sep 2023 16:48:11 +0200 Subject: [PATCH 4/4] chore(release): publish --- CHANGELOG.md | 16 ++++++++++++++++ lerna.json | 2 +- packages/components-angular/CHANGELOG.md | 8 ++++++++ packages/components-angular/package.json | 2 +- packages/components-react/CHANGELOG.md | 8 ++++++++ packages/components-react/package.json | 2 +- packages/components-vue/CHANGELOG.md | 8 ++++++++ packages/components-vue/package.json | 2 +- packages/components/CHANGELOG.md | 16 ++++++++++++++++ packages/components/package.json | 4 ++-- packages/design-tokens/CHANGELOG.md | 8 ++++++++ packages/design-tokens/package.json | 2 +- packages/storybook-vue/CHANGELOG.md | 16 ++++++++++++++++ packages/storybook-vue/package.json | 6 +++--- packages/visual-tests/CHANGELOG.md | 8 ++++++++ packages/visual-tests/package.json | 2 +- 16 files changed, 99 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 750abf0887..20e3b9dd45 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,22 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.140](https://github.com/telekom/scale/compare/v3.0.0-beta.139...v3.0.0-beta.140) (2023-09-13) + + +### Bug Fixes + +* **radio-button:** ensure change event is emitted when clicking input-label gap ([#2123](https://github.com/telekom/scale/issues/2123)) ([5423cb8](https://github.com/telekom/scale/commit/5423cb80520f93aae52eab4ff6a5477dcd072f09)) + + +### Features + +* **data-grid:** enable localization for flyout menu ([#1411](https://github.com/telekom/scale/issues/1411)) ([053b10d](https://github.com/telekom/scale/commit/053b10d4e75616059a889b6e1d26012645eda97d)) + + + + + # [3.0.0-beta.139](https://github.com/telekom/scale/compare/v3.0.0-beta.138...v3.0.0-beta.139) (2023-09-06) diff --git a/lerna.json b/lerna.json index d95fe69b6d..2ffb65698b 100644 --- a/lerna.json +++ b/lerna.json @@ -7,7 +7,7 @@ "--pure-lockfile" ], "useWorkspaces": true, - "version": "3.0.0-beta.139", + "version": "3.0.0-beta.140", "command": { "version": { "allowBranch": "main" diff --git a/packages/components-angular/CHANGELOG.md b/packages/components-angular/CHANGELOG.md index d34da70496..ccd69de434 100644 --- a/packages/components-angular/CHANGELOG.md +++ b/packages/components-angular/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.140](https://github.com/telekom/scale/compare/v3.0.0-beta.139...v3.0.0-beta.140) (2023-09-13) + +**Note:** Version bump only for package @telekom/scale-components-angular + + + + + # [3.0.0-beta.139](https://github.com/telekom/scale/compare/v3.0.0-beta.138...v3.0.0-beta.139) (2023-09-06) **Note:** Version bump only for package @telekom/scale-components-angular diff --git a/packages/components-angular/package.json b/packages/components-angular/package.json index e39fccecce..4eb56a0519 100644 --- a/packages/components-angular/package.json +++ b/packages/components-angular/package.json @@ -1,6 +1,6 @@ { "name": "@telekom/scale-components-angular", - "version": "3.0.0-beta.139", + "version": "3.0.0-beta.140", "description": "Angular specific wrapper for @telekom/scale-components", "license": "MPL-2.0", "homepage": "https://github.com/telekom/scale", diff --git a/packages/components-react/CHANGELOG.md b/packages/components-react/CHANGELOG.md index 6260d805ba..04d5ac9cdc 100644 --- a/packages/components-react/CHANGELOG.md +++ b/packages/components-react/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.140](https://github.com/telekom/scale/compare/v3.0.0-beta.139...v3.0.0-beta.140) (2023-09-13) + +**Note:** Version bump only for package @telekom/scale-components-react + + + + + # [3.0.0-beta.139](https://github.com/telekom/scale/compare/v3.0.0-beta.138...v3.0.0-beta.139) (2023-09-06) **Note:** Version bump only for package @telekom/scale-components-react diff --git a/packages/components-react/package.json b/packages/components-react/package.json index 8f3ae586b9..673d0aec26 100755 --- a/packages/components-react/package.json +++ b/packages/components-react/package.json @@ -1,7 +1,7 @@ { "name": "@telekom/scale-components-react", "sideEffects": false, - "version": "3.0.0-beta.139", + "version": "3.0.0-beta.140", "description": "React proxy for @telekom/scale-components", "license": "MPL-2.0", "homepage": "https://github.com/telekom/scale", diff --git a/packages/components-vue/CHANGELOG.md b/packages/components-vue/CHANGELOG.md index 03d1cfe2b0..463a10869c 100644 --- a/packages/components-vue/CHANGELOG.md +++ b/packages/components-vue/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.140](https://github.com/telekom/scale/compare/v3.0.0-beta.139...v3.0.0-beta.140) (2023-09-13) + +**Note:** Version bump only for package @telekom/scale-components-vue + + + + + # [3.0.0-beta.139](https://github.com/telekom/scale/compare/v3.0.0-beta.138...v3.0.0-beta.139) (2023-09-06) **Note:** Version bump only for package @telekom/scale-components-vue diff --git a/packages/components-vue/package.json b/packages/components-vue/package.json index 0dd9a5e5d8..4e03ca4989 100644 --- a/packages/components-vue/package.json +++ b/packages/components-vue/package.json @@ -1,7 +1,7 @@ { "name": "@telekom/scale-components-vue", "sideEffects": false, - "version": "3.0.0-beta.139", + "version": "3.0.0-beta.140", "description": "Vue specific wrapper for @telekom/scale-components", "license": "MPL-2.0", "homepage": "https://github.com/telekom/scale", diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 57b65930cf..eac16e08d4 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -3,6 +3,22 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.140](https://github.com/telekom/scale/compare/v3.0.0-beta.139...v3.0.0-beta.140) (2023-09-13) + + +### Bug Fixes + +* **radio-button:** ensure change event is emitted when clicking input-label gap ([#2123](https://github.com/telekom/scale/issues/2123)) ([5423cb8](https://github.com/telekom/scale/commit/5423cb80520f93aae52eab4ff6a5477dcd072f09)) + + +### Features + +* **data-grid:** enable localization for flyout menu ([#1411](https://github.com/telekom/scale/issues/1411)) ([053b10d](https://github.com/telekom/scale/commit/053b10d4e75616059a889b6e1d26012645eda97d)) + + + + + # [3.0.0-beta.139](https://github.com/telekom/scale/compare/v3.0.0-beta.138...v3.0.0-beta.139) (2023-09-06) diff --git a/packages/components/package.json b/packages/components/package.json index 3a57be2ae6..2c24b9122b 100644 --- a/packages/components/package.json +++ b/packages/components/package.json @@ -1,6 +1,6 @@ { "name": "@telekom/scale-components", - "version": "3.0.0-beta.139", + "version": "3.0.0-beta.140", "description": "Scale is the digital design system for Telekom products and experiences.", "homepage": "https://github.com/telekom/scale", "repository": { @@ -72,7 +72,7 @@ "@floating-ui/dom": "^0.5.4", "@stencil/core": "^2.17.0", "@telekom/design-tokens": "1.0.0-beta.8", - "@telekom/scale-design-tokens": "^3.0.0-beta.139", + "@telekom/scale-design-tokens": "^3.0.0-beta.140", "classnames": "^2.2.6", "stencil-inline-svg": "^1.0.1" } diff --git a/packages/design-tokens/CHANGELOG.md b/packages/design-tokens/CHANGELOG.md index 91b374930c..926b692d2b 100644 --- a/packages/design-tokens/CHANGELOG.md +++ b/packages/design-tokens/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.140](https://github.com/telekom/scale/compare/v3.0.0-beta.139...v3.0.0-beta.140) (2023-09-13) + +**Note:** Version bump only for package @telekom/scale-design-tokens + + + + + # [3.0.0-beta.139](https://github.com/telekom/scale/compare/v3.0.0-beta.138...v3.0.0-beta.139) (2023-09-06) **Note:** Version bump only for package @telekom/scale-design-tokens diff --git a/packages/design-tokens/package.json b/packages/design-tokens/package.json index f02e33b3bc..839dea13e4 100644 --- a/packages/design-tokens/package.json +++ b/packages/design-tokens/package.json @@ -1,6 +1,6 @@ { "name": "@telekom/scale-design-tokens", - "version": "3.0.0-beta.139", + "version": "3.0.0-beta.140", "type": "module", "description": "Design Tokens for the Scale Design System", "homepage": "https://github.com/telekom/scale", diff --git a/packages/storybook-vue/CHANGELOG.md b/packages/storybook-vue/CHANGELOG.md index 92d0fe7ab1..82f92f80a9 100644 --- a/packages/storybook-vue/CHANGELOG.md +++ b/packages/storybook-vue/CHANGELOG.md @@ -3,6 +3,22 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.140](https://github.com/telekom/scale/compare/v3.0.0-beta.139...v3.0.0-beta.140) (2023-09-13) + + +### Bug Fixes + +* **radio-button:** ensure change event is emitted when clicking input-label gap ([#2123](https://github.com/telekom/scale/issues/2123)) ([5423cb8](https://github.com/telekom/scale/commit/5423cb80520f93aae52eab4ff6a5477dcd072f09)) + + +### Features + +* **data-grid:** enable localization for flyout menu ([#1411](https://github.com/telekom/scale/issues/1411)) ([053b10d](https://github.com/telekom/scale/commit/053b10d4e75616059a889b6e1d26012645eda97d)) + + + + + # [3.0.0-beta.139](https://github.com/telekom/scale/compare/v3.0.0-beta.138...v3.0.0-beta.139) (2023-09-06) **Note:** Version bump only for package @telekom/scale-storybook-vue diff --git a/packages/storybook-vue/package.json b/packages/storybook-vue/package.json index 2aedf51bf6..eaf56feb2a 100644 --- a/packages/storybook-vue/package.json +++ b/packages/storybook-vue/package.json @@ -2,7 +2,7 @@ "homepage": "https://telekom.github.io/scale", "name": "@telekom/scale-storybook-vue", "private": true, - "version": "3.0.0-beta.139", + "version": "3.0.0-beta.140", "main": "index.js", "license": "MPL-2.0", "devDependencies": { @@ -32,8 +32,8 @@ "dependencies": { "@storybook/addon-viewport": "^6.4.22", "@telekom/design-tokens": "^1.0.0-beta.2", - "@telekom/scale-components": "^3.0.0-beta.139", - "@telekom/scale-components-vue": "^3.0.0-beta.139" + "@telekom/scale-components": "^3.0.0-beta.140", + "@telekom/scale-components-vue": "^3.0.0-beta.140" }, "scripts": { "prestart": "rm -rf node_modules/.cache/ && yes | cp -a ../components/dist/scale-components/fonts/* public/fonts/ && yes | cp -a ../components/dist/scale-components/scale-components.css public/", diff --git a/packages/visual-tests/CHANGELOG.md b/packages/visual-tests/CHANGELOG.md index a136f4fbd1..ed3367038b 100644 --- a/packages/visual-tests/CHANGELOG.md +++ b/packages/visual-tests/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.140](https://github.com/telekom/scale/compare/v3.0.0-beta.139...v3.0.0-beta.140) (2023-09-13) + +**Note:** Version bump only for package @telekom/scale-visual-tests + + + + + # [3.0.0-beta.139](https://github.com/telekom/scale/compare/v3.0.0-beta.138...v3.0.0-beta.139) (2023-09-06) **Note:** Version bump only for package @telekom/scale-visual-tests diff --git a/packages/visual-tests/package.json b/packages/visual-tests/package.json index 4442dd89f9..3f5301a8fb 100644 --- a/packages/visual-tests/package.json +++ b/packages/visual-tests/package.json @@ -1,7 +1,7 @@ { "name": "@telekom/scale-visual-tests", "private": true, - "version": "3.0.0-beta.139", + "version": "3.0.0-beta.140", "main": "index.js", "license": "MPL-2.0", "scripts": {