Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract component styles to core #5282

Merged
merged 11 commits into from
Jan 23, 2025
Merged

Extract component styles to core #5282

merged 11 commits into from
Jan 23, 2025

Conversation

epetrow
Copy link
Contributor

@epetrow epetrow commented Jan 7, 2025 •
edited
Loading

closes: #305

@epetrow epetrow changed the title chore: extract component styles to core WIP: Extract component styles to core Jan 7, 2025
@epetrow epetrow force-pushed the extract-component-styles branch 5 times, most recently from d7dba3d to 6265b23 Compare January 9, 2025 11:15
@epetrow epetrow self-assigned this Jan 9, 2025
@epetrow epetrow force-pushed the extract-component-styles branch 9 times, most recently from ce716a6 to b13c1d1 Compare January 13, 2025 12:55
@epetrow epetrow marked this pull request as ready for review January 13, 2025 13:00
@epetrow epetrow requested a review from a team as a code owner January 13, 2025 13:00
@epetrow epetrow changed the title WIP: Extract component styles to core Extract component styles to core Jan 13, 2025
@epetrow epetrow added this to the 2025 Q1 (Feb) milestone Jan 13, 2025
@epetrow epetrow force-pushed the extract-component-styles branch from b13c1d1 to f33b7b6 Compare January 13, 2025 14:32
@zhpenkov zhpenkov self-requested a review January 14, 2025 12:52
@epetrow epetrow force-pushed the extract-component-styles branch 2 times, most recently from 3274f76 to 3652014 Compare January 14, 2025 17:01
@zhpenkov
Copy link
Contributor

ab83343
We should consider generating our metadata/docs from the core in the future to reduce maintenence.
As of now, it is not possible as the script needs to be adjusted.

@inikolova inikolova self-requested a review January 20, 2025 09:33
@epetrow epetrow force-pushed the extract-component-styles branch 2 times, most recently from 733faa9 to cadf789 Compare January 22, 2025 09:04
@epetrow epetrow marked this pull request as draft January 22, 2025 09:11
zhpenkov
zhpenkov reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@zhpenkov zhpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might also consider replacing the previously added unset values with null.

@epetrow epetrow force-pushed the extract-component-styles branch 3 times, most recently from 7b9f1d7 to cb1ec79 Compare January 22, 2025 11:32
@epetrow epetrow marked this pull request as ready for review January 22, 2025 11:51
@epetrow epetrow force-pushed the extract-component-styles branch from 2593251 to 41a14c7 Compare January 23, 2025 13:59
@TeyaVes TeyaVes self-requested a review January 23, 2025 14:28
@epetrow epetrow requested a review from zhpenkov January 23, 2025 14:36
@epetrow epetrow force-pushed the extract-component-styles branch from 41a14c7 to f39eaf3 Compare January 23, 2025 15:47
@epetrow epetrow merged commit bff455c into develop Jan 23, 2025
27 checks passed
@epetrow epetrow deleted the extract-component-styles branch January 23, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inikolova inikolova inikolova approved these changes

@TeyaVes TeyaVes TeyaVes approved these changes

@zhpenkov zhpenkov zhpenkov approved these changes

Assignees

@epetrow epetrow

Labels
Internal
Projects
None yet
Milestone
2025 Q1 (Feb)
Development

Successfully merging this pull request may close these issues.
4 participants
@epetrow @zhpenkov @inikolova @TeyaVes