Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS for TabStripItem generates obsolete CSS class k-tabstrip-item and causes styling mismatches #131

Open
NickIliev opened this issue Nov 26, 2024 · 3 comments

Comments

@NickIliev
Copy link
Member

Describe the bug
In TB Q4 2024 when a style is set for a TabStripItem, the application generates CSS selector that contains CSS class k-tabstip-item (note this class is different from the k-tabstrip-items wrapper class)

However, this class is no longer present in the source of truth and is not used in some Telerik/Kendo suites like Telerik Blazor. It is still present in Kedno React which causes the ThemeBuilder's templates and previews to work but only with Kendo React.

To Reproduce
Steps to reproduce the behavior:

Source of truth:
Image

Blazor rendering for TabStrip position demo:
Image

TB generated CSS:
Image

Expected behavior
ThemeBuilder to generate CS that does not contain k-tabstrip-item

Components technology and version
Telerik Blazor 7.0.0
ThemeBuilder Q2 2024
Kendo Default Theme 10.0.0

Additional context
reported through t.1671577

@NickIliev
Copy link
Member Author

Update: The KendoReact team will remove the obsolete CSS class k-tasbstrip-item as discussed here

@NickIliev
Copy link
Member Author

NickIliev commented Dec 5, 2024

Update: the rendering was updated in the source of truth tests as per https://github.com/telerik/kendo-themes/blame/develop/tests/tabstrip/tabstrip.html#L18

So now the issue will be fixed in Telerik UI for Blazor, where the k-tabstrip-item class should be added.

Will be fixed through https://feedback.telerik.com/blazor/1672602-the-class-k-tabstrip-item-is-missing-in-the-rendering-of-the-tabstrip-component

@NickIliev NickIliev reopened this Feb 5, 2025
@NickIliev
Copy link
Member Author

NickIliev commented Feb 5, 2025

+1 from t.1673045 for ASP.NET Core, where the CSS classes are still present.

Consider fixing the issue within ThemeBuilder buy removing the following classes:

k-tabstrip-item
k-tabstip-items-start

x
/* 
    Custom solution for the specific rendering difference in the TabStrip in UI for ASP.NET Core 
    We removed the .k-tabstip-items-start and the .k-tabstrip-item CSS classes
    from all generated styles that are related to .k-tabstrip
*/
.k-tabstrip .k-tabstrip-items-wrapper .k-tabstrip-items.k-reset .k-item {
    color: #00156e;
    background-color: initial;
    background-image: none;
    font-size: 12px;
}

.k-tabstrip .k-tabstrip-items-wrapper.k-hstack .k-tabstrip-items.k-reset {
    background-color: #bfdbff;
    background-image: none;
}

.k-tabstrip .k-tabstrip-items-wrapper .k-tabstrip-items.k-reset .k-item.k-focus .k-link,
.k-tabstrip .k-tabstrip-items-wrapper .k-tabstrip-items.k-reset .k-item.k-state-focus .k-link,
.k-tabstrip .k-tabstrip-items-wrapper .k-tabstrip-items.k-reset .k-item.k-state-focused .k-link,
.k-tabstrip .k-tabstrip-items-wrapper .k-tabstrip-items.k-reset .k-item:focus .k-link {
    background-color: whitesmoke;
    background-image: none;
}

Logged in UI for ASP>NET Core through telerik/kendo-ui-core#8131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant