-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS for TabStripItem generates obsolete CSS class k-tabstrip-item and causes styling mismatches #131
Comments
Update: The KendoReact team will remove the obsolete CSS class k-tasbstrip-item as discussed here |
Update: the rendering was updated in the source of truth tests as per https://github.com/telerik/kendo-themes/blame/develop/tests/tabstrip/tabstrip.html#L18 So now the issue will be fixed in Telerik UI for Blazor, where the k-tabstrip-item class should be added. Will be fixed through https://feedback.telerik.com/blazor/1672602-the-class-k-tabstrip-item-is-missing-in-the-rendering-of-the-tabstrip-component |
+1 from t.1673045 for ASP.NET Core, where the CSS classes are still present. Consider fixing the issue within ThemeBuilder buy removing the following classes: k-tabstrip-item x
/*
Custom solution for the specific rendering difference in the TabStrip in UI for ASP.NET Core
We removed the .k-tabstip-items-start and the .k-tabstrip-item CSS classes
from all generated styles that are related to .k-tabstrip
*/
.k-tabstrip .k-tabstrip-items-wrapper .k-tabstrip-items.k-reset .k-item {
color: #00156e;
background-color: initial;
background-image: none;
font-size: 12px;
}
.k-tabstrip .k-tabstrip-items-wrapper.k-hstack .k-tabstrip-items.k-reset {
background-color: #bfdbff;
background-image: none;
}
.k-tabstrip .k-tabstrip-items-wrapper .k-tabstrip-items.k-reset .k-item.k-focus .k-link,
.k-tabstrip .k-tabstrip-items-wrapper .k-tabstrip-items.k-reset .k-item.k-state-focus .k-link,
.k-tabstrip .k-tabstrip-items-wrapper .k-tabstrip-items.k-reset .k-item.k-state-focused .k-link,
.k-tabstrip .k-tabstrip-items-wrapper .k-tabstrip-items.k-reset .k-item:focus .k-link {
background-color: whitesmoke;
background-image: none;
} Logged in UI for ASP>NET Core through telerik/kendo-ui-core#8131 |
Describe the bug
In TB Q4 2024 when a style is set for a TabStripItem, the application generates CSS selector that contains CSS class k-tabstip-item (note this class is different from the k-tabstrip-items wrapper class)
However, this class is no longer present in the source of truth and is not used in some Telerik/Kendo suites like Telerik Blazor. It is still present in Kedno React which causes the ThemeBuilder's templates and previews to work but only with Kendo React.
To Reproduce
Steps to reproduce the behavior:
Source of truth:
![Image](https://private-user-images.githubusercontent.com/18008302/389938694-9cc778e8-63b7-486a-b2af-52b9dd139d17.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMjY0MjAsIm5iZiI6MTczOTIyNjEyMCwicGF0aCI6Ii8xODAwODMwMi8zODk5Mzg2OTQtOWNjNzc4ZTgtNjNiNy00ODZhLWIyYWYtNTJiOWRkMTM5ZDE3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDIyMjIwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkzMWI5MzUwMjZiODJiYmNjOWVhNDQ0MDhjZTk1YjM1MWRkYjMyZmFkN2Y1N2NhNDNkYTZlYzFhYjk1NzA2NGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qbY_eMqEEezA4gqRGg3s49MiUqGNTr6AFHwR4eJPPco)
Blazor rendering for TabStrip position demo:
![Image](https://private-user-images.githubusercontent.com/18008302/389939549-d175127f-ad34-4564-b487-22fdfe23e4ca.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMjY0MjAsIm5iZiI6MTczOTIyNjEyMCwicGF0aCI6Ii8xODAwODMwMi8zODk5Mzk1NDktZDE3NTEyN2YtYWQzNC00NTY0LWI0ODctMjJmZGZlMjNlNGNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDIyMjIwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVlNGFhOGQ4NmRkYzZhMzI0NzA2NWVkMDlmZDg1Yzk4MjY4OTlkOGM4M2VhZjBhYzQyZmM5ZjQ4NGMwYmFhYzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.o-MI9SKHCcntzxE3pCbIhCU8nnCr5_XiRjANFONwNxY)
TB generated CSS:
![Image](https://private-user-images.githubusercontent.com/18008302/389938714-12a83164-5962-4efa-82a1-ca149f95187f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMjY0MjAsIm5iZiI6MTczOTIyNjEyMCwicGF0aCI6Ii8xODAwODMwMi8zODk5Mzg3MTQtMTJhODMxNjQtNTk2Mi00ZWZhLTgyYTEtY2ExNDlmOTUxODdmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDIyMjIwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU1YTQ2MTVmMzM1MzBiODIyZGZiNGFiMDYzNTdjNjMxOGQxMDQ2ODA3MWQzMWRmOWU2YzNjMTYxY2JmOGI5YWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CC9WAiN-z27OHhbL7bNObGS240clB2_iyZJBRVYgxEw)
Expected behavior
ThemeBuilder to generate CS that does not contain k-tabstrip-item
Components technology and version
Telerik Blazor 7.0.0
ThemeBuilder Q2 2024
Kendo Default Theme 10.0.0
Additional context
reported through t.1671577
The text was updated successfully, but these errors were encountered: