Consolidate migration folder in OSS #6893
Open
+717
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zigeH
force-pushed
the
consolidate-force-replication-wf
branch
from
d0276d0 to
99ed161
Compare
…' into consolidate-force-replication-wf
zigeH
changed the title
hehaifengcn
reviewed
Nov 27, 2024
| if !isNotFoundServiceError(err) { | ||
| a.logger.Error("force-replication failed to generate replication task", tag.WorkflowNamespaceID(request.NamespaceID), tag.WorkflowID(we.WorkflowId), tag.WorkflowRunID(we.RunId), tag.Error(err)) | ||
| var executionCandidates []definition.WorkflowKey | ||
| if request.EnableParentInfo { |
There was a problem hiding this comment.
Do we want to expose this in OSS? my understanding is that we may take a different approach. @yux0 ?
There was a problem hiding this comment.
agree. We can remove this part and use the new approach.
There was a problem hiding this comment.
But I think we will not keep 2 version of this code. After the pr got merged, force-replication on the saas-temporal will be deleted.
There was a problem hiding this comment.
Or are we going to modify generateReplicationTasks before consolidation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
1, Consolidate force replication and handover wf in OSS with control plane.
2, We copied all 7 files from cp and remove the prefix saas.
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?