From 79d8e798d6297512a97dede678c5384a217ff107 Mon Sep 17 00:00:00 2001 From: Laura Whitaker Date: Tue, 17 Dec 2024 09:55:04 -0700 Subject: [PATCH] Remove rounded borders (#2449) * Change borders from 2px to 1px * Change ring from 4px to 2px * Remove rounded border in layout and components * Remove rounded border for input components * Remove rounded border for button component * Remove rounded border for other Holocene components * Remove more rounded borders * Remove unnecessary table data cells * Remove rounding on signin and login pages --- .../components/batch-operations/table.svelte | 3 -- .../components/bottom-nav-namespaces.svelte | 2 +- src/lib/components/bottom-nav.svelte | 4 +- .../event/event-details-full.svelte | 4 +- .../components/event/event-details-row.svelte | 2 +- .../components/event/event-summary-row.svelte | 12 +----- .../event/pending-activity-summary-row.svelte | 4 +- .../event/pending-nexus-summary-row.svelte | 4 +- src/lib/components/feedback-button.svelte | 10 +---- .../import/event-history-file-import.svelte | 2 +- .../lines-and-dots/workflow-error.svelte | 2 +- src/lib/components/login-button.svelte | 2 +- src/lib/components/panel.svelte | 2 +- .../schedule/schedule-basic-frequency.svelte | 2 +- .../conditional-menu.svelte | 4 +- .../duration-filter.svelte | 3 +- .../search-attribute-filter/index.svelte | 9 ---- .../list-filter.svelte | 13 ++---- .../number-filter.svelte | 3 +- .../search-attribute-menu.svelte | 2 +- .../text-filter.svelte | 3 +- .../components/worker-compatibility.svelte | 6 +-- src/lib/components/worker-rules.svelte | 4 +- src/lib/components/worker-table.svelte | 4 +- .../batch-operation-confirmation-form.svelte | 2 +- .../dropdown-filter/conditional.svelte | 10 +---- .../workflow/input-and-results.svelte | 2 +- .../workflow/workflow-advanced-search.svelte | 4 +- .../workflow/workflow-counts.svelte | 2 +- .../table-header-row.svelte | 7 +--- .../table-row.svelte | 3 -- .../holocene/accordion/accordion-group.svelte | 4 +- .../holocene/accordion/accordion-light.svelte | 2 +- src/lib/holocene/accordion/accordion.svelte | 11 ++--- src/lib/holocene/alert.svelte | 2 +- src/lib/holocene/button.stories.svelte | 8 ---- src/lib/holocene/button.svelte | 15 ------- src/lib/holocene/card.svelte | 2 +- src/lib/holocene/checkbox.svelte | 1 - src/lib/holocene/chip.svelte | 2 +- src/lib/holocene/combobox/combobox.svelte | 2 +- src/lib/holocene/compatibility-badge.svelte | 4 +- src/lib/holocene/copyable/button.svelte | 2 +- src/lib/holocene/drawer.svelte | 3 +- src/lib/holocene/empty-state.svelte | 2 +- src/lib/holocene/file-input.svelte | 2 +- src/lib/holocene/input/chip-input.svelte | 18 +------- src/lib/holocene/input/input.stories.svelte | 10 ----- src/lib/holocene/input/input.svelte | 24 +++-------- .../input/number-input.stories.svelte | 10 ----- src/lib/holocene/input/number-input.svelte | 29 ++----------- src/lib/holocene/input/range-input.svelte | 2 +- .../keyboard-shortcut/shortcut.svelte | 2 +- src/lib/holocene/link.svelte | 2 +- src/lib/holocene/menu/menu-item.svelte | 2 +- src/lib/holocene/menu/menu.svelte | 2 +- src/lib/holocene/modal.svelte | 2 +- src/lib/holocene/monaco/markdown.svelte | 2 +- .../navigation/navigation-badge.svelte | 2 +- .../navigation/navigation-button.svelte | 4 +- .../navigation/navigation-container.svelte | 4 +- .../navigation/navigation-item.svelte | 4 +- .../orderable-list/orderable-list-item.svelte | 6 +-- .../orderable-list/orderable-list.svelte | 2 +- src/lib/holocene/select/simple-select.svelte | 7 +--- src/lib/holocene/tab/tab.svelte | 2 +- .../table/paginated-table/index.svelte | 6 +-- .../holocene/table/table-header-row.svelte | 2 - src/lib/holocene/table/table-row.svelte | 2 - src/lib/holocene/table/table.svelte | 42 ++----------------- src/lib/holocene/textarea.svelte | 4 +- .../toggle-button/toggle-button.svelte | 9 ---- src/lib/holocene/tooltip.svelte | 2 +- src/lib/holocene/user-menu.svelte | 4 +- src/lib/layouts/workflow-header.svelte | 7 +--- .../layouts/workflow-history-layout.svelte | 2 +- src/lib/layouts/workflow-run-layout.svelte | 2 +- src/lib/pages/nexus-endpoint.svelte | 2 +- src/lib/pages/nexus-endpoints.svelte | 2 +- src/lib/vendor/codemirror/theme.ts | 1 - .../(app)/select-namespace/+page.svelte | 6 +-- src/routes/(login)/login/+page.svelte | 4 +- src/routes/(login)/signin/+page.svelte | 4 +- 83 files changed, 107 insertions(+), 328 deletions(-) diff --git a/src/lib/components/batch-operations/table.svelte b/src/lib/components/batch-operations/table.svelte index 2fe83d378..df8da6fd0 100644 --- a/src/lib/components/batch-operations/table.svelte +++ b/src/lib/components/batch-operations/table.svelte @@ -62,9 +62,6 @@ - - - {/each} diff --git a/src/lib/components/bottom-nav-namespaces.svelte b/src/lib/components/bottom-nav-namespaces.svelte index eac4dbdec..889044e43 100644 --- a/src/lib/components/bottom-nav-namespaces.svelte +++ b/src/lib/components/bottom-nav-namespaces.svelte @@ -45,7 +45,7 @@ diff --git a/src/lib/components/event/event-details-full.svelte b/src/lib/components/event/event-details-full.svelte index 57b170274..ae9b61fcb 100644 --- a/src/lib/components/event/event-details-full.svelte +++ b/src/lib/components/event/event-details-full.svelte @@ -20,7 +20,7 @@ {#if showEventGroup}
{#each group.eventList as groupEvent} {@const attributes = formatAttributes(groupEvent)} @@ -76,7 +76,7 @@ {@const attributes = formatAttributes(event)} {@const details = Object.entries(attributes)}
-
+
{#each details as [key, value] (key)} diff --git a/src/lib/components/event/event-details-row.svelte b/src/lib/components/event/event-details-row.svelte index 491665be7..02797b30f 100644 --- a/src/lib/components/event/event-details-row.svelte +++ b/src/lib/components/event/event-details-row.svelte @@ -61,6 +61,6 @@ diff --git a/src/lib/components/event/event-summary-row.svelte b/src/lib/components/event/event-summary-row.svelte index e5be88cba..628004a65 100644 --- a/src/lib/components/event/event-summary-row.svelte +++ b/src/lib/components/event/event-summary-row.svelte @@ -181,7 +181,7 @@ {#if pendingAttempt}
{translate('workflows.attempt')} @@ -227,7 +227,7 @@ class:typedError class="row expanded" > - + @@ -269,12 +269,4 @@ .typedError .expanded-cell { @apply border-b-0; } - - .row.typedError { - @apply rounded-lg; - - &.expanded { - @apply rounded-b-none; - } - } diff --git a/src/lib/components/event/pending-activity-summary-row.svelte b/src/lib/components/event/pending-activity-summary-row.svelte index 7af85a5c5..cbeb3a2f3 100644 --- a/src/lib/components/event/pending-activity-summary-row.svelte +++ b/src/lib/components/event/pending-activity-summary-row.svelte @@ -57,7 +57,7 @@

{translate('workflows.attempt')} @@ -82,7 +82,7 @@ {#if expanded} - + diff --git a/src/lib/components/event/pending-nexus-summary-row.svelte b/src/lib/components/event/pending-nexus-summary-row.svelte index dd277ec06..c6cbab1ed 100644 --- a/src/lib/components/event/pending-nexus-summary-row.svelte +++ b/src/lib/components/event/pending-nexus-summary-row.svelte @@ -58,7 +58,7 @@ {#if event.attempt}
{translate('workflows.attempt')} @@ -79,7 +79,7 @@ {#if expanded} - + diff --git a/src/lib/components/feedback-button.svelte b/src/lib/components/feedback-button.svelte index f072373aa..48b15b920 100644 --- a/src/lib/components/feedback-button.svelte +++ b/src/lib/components/feedback-button.svelte @@ -10,23 +10,17 @@ diff --git a/src/lib/components/import/event-history-file-import.svelte b/src/lib/components/import/event-history-file-import.svelte index 49cfa7f3f..6b8465668 100644 --- a/src/lib/components/import/event-history-file-import.svelte +++ b/src/lib/components/import/event-history-file-import.svelte @@ -67,7 +67,7 @@ /> {/if}
diff --git a/src/lib/components/login-button.svelte b/src/lib/components/login-button.svelte index 3c05d6510..2933069a1 100644 --- a/src/lib/components/login-button.svelte +++ b/src/lib/components/login-button.svelte @@ -13,7 +13,7 @@ diff --git a/src/lib/components/search-attribute-filter/conditional-menu.svelte b/src/lib/components/search-attribute-filter/conditional-menu.svelte index 82c7ac86e..21cbe8970 100644 --- a/src/lib/components/search-attribute-filter/conditional-menu.svelte +++ b/src/lib/components/search-attribute-filter/conditional-menu.svelte @@ -59,9 +59,7 @@ diff --git a/src/lib/components/search-attribute-filter/list-filter.svelte b/src/lib/components/search-attribute-filter/list-filter.svelte index 55748999c..d0f547b0c 100644 --- a/src/lib/components/search-attribute-filter/list-filter.svelte +++ b/src/lib/components/search-attribute-filter/list-filter.svelte @@ -44,20 +44,14 @@ labelHidden id="list-filter" bind:chips - class="w-full" + class="w-full [&_*]:border-l-0 [&_*]:border-r-0" removeChipButtonLabel={(chip) => translate('workflows.remove-keyword-label', { keyword: chip })} placeholder="{translate('common.enter')} {$filter.attribute}" - unroundLeft - unroundRight external />
- @@ -70,8 +64,7 @@ type="search" placeholder={`${translate('common.enter')} ${$filter.attribute}`} icon="search" - class="w-full" - unroundLeft + class="w-full [&_*]:border-l-0" bind:value={_value} on:keydown={handleKeydown} /> diff --git a/src/lib/components/search-attribute-filter/number-filter.svelte b/src/lib/components/search-attribute-filter/number-filter.svelte index fc77793f9..606916203 100644 --- a/src/lib/components/search-attribute-filter/number-filter.svelte +++ b/src/lib/components/search-attribute-filter/number-filter.svelte @@ -34,8 +34,7 @@ bind:value={_value} {min} on:keydown={handleKeydown} - unroundLeft search - class="-mr-2" + class="-mr-2 [&_*]:border-l-0" /> diff --git a/src/lib/components/search-attribute-filter/search-attribute-menu.svelte b/src/lib/components/search-attribute-filter/search-attribute-menu.svelte index 6c4ab4daf..ff9522f35 100644 --- a/src/lib/components/search-attribute-filter/search-attribute-menu.svelte +++ b/src/lib/components/search-attribute-filter/search-attribute-menu.svelte @@ -57,7 +57,7 @@ disabled={$activeQueryIndex !== null} count={$filter.attribute ? 0 : filters.length} on:click={() => (searchAttributeValue = '')} - class="text-nowrap {!!$filter.attribute && 'attribute-selected'}" + class="text-nowrap" > {#if !$filter.attribute} diff --git a/src/lib/components/search-attribute-filter/text-filter.svelte b/src/lib/components/search-attribute-filter/text-filter.svelte index 563bc0555..6b555c728 100644 --- a/src/lib/components/search-attribute-filter/text-filter.svelte +++ b/src/lib/components/search-attribute-filter/text-filter.svelte @@ -39,8 +39,7 @@ type="search" placeholder={`${translate('common.enter')} ${$filter.attribute}`} icon="search" - class="w-full" - unroundLeft + class="w-full [&_*]:border-l-0" bind:value={_value} on:keydown={handleKeydown} /> diff --git a/src/lib/components/worker-compatibility.svelte b/src/lib/components/worker-compatibility.svelte index 86271e0df..18122daa5 100644 --- a/src/lib/components/worker-compatibility.svelte +++ b/src/lib/components/worker-compatibility.svelte @@ -71,7 +71,7 @@ {:else} - + @@ -79,7 +79,7 @@

{translate('workers.workers')} - {workers?.pollers?.length || 0} + {workers?.pollers?.length || 0}

- diff --git a/src/lib/components/worker-rules.svelte b/src/lib/components/worker-rules.svelte index 6cca06239..5dc68b047 100644 --- a/src/lib/components/worker-rules.svelte +++ b/src/lib/components/worker-rules.svelte @@ -60,7 +60,7 @@ {:else} - @@ -104,7 +104,7 @@ {:else} - diff --git a/src/lib/components/worker-table.svelte b/src/lib/components/worker-table.svelte index c4f7cdf34..17c3bea5d 100644 --- a/src/lib/components/worker-table.svelte +++ b/src/lib/components/worker-table.svelte @@ -16,7 +16,7 @@

{translate('workers.workers')} - {workers?.pollers?.length || 0} + {workers?.pollers?.length || 0}

{:else}
+
+
+
- diff --git a/src/lib/components/workflow/client-actions/batch-operation-confirmation-form.svelte b/src/lib/components/workflow/client-actions/batch-operation-confirmation-form.svelte index 608a438b1..d16a6f01d 100644 --- a/src/lib/components/workflow/client-actions/batch-operation-confirmation-form.svelte +++ b/src/lib/components/workflow/client-actions/batch-operation-confirmation-form.svelte @@ -71,7 +71,7 @@ />

{$workflowsQuery} diff --git a/src/lib/components/workflow/dropdown-filter/conditional.svelte b/src/lib/components/workflow/dropdown-filter/conditional.svelte index 1dc4830c8..baffba2ed 100644 --- a/src/lib/components/workflow/dropdown-filter/conditional.svelte +++ b/src/lib/components/workflow/dropdown-filter/conditional.svelte @@ -4,18 +4,12 @@
{:else} - + {/if} {/each}
diff --git a/src/lib/components/workflow/workflows-summary-configurable-table/table-header-row.svelte b/src/lib/components/workflow/workflows-summary-configurable-table/table-header-row.svelte index da24da995..1d376e34b 100644 --- a/src/lib/components/workflow/workflows-summary-configurable-table/table-header-row.svelte +++ b/src/lib/components/workflow/workflows-summary-configurable-table/table-header-row.svelte @@ -56,19 +56,14 @@ {:else} {/if} -
diff --git a/src/lib/components/workflow/workflows-summary-configurable-table/table-row.svelte b/src/lib/components/workflow/workflows-summary-configurable-table/table-row.svelte index 06bff9e59..575734d96 100644 --- a/src/lib/components/workflow/workflows-summary-configurable-table/table-row.svelte +++ b/src/lib/components/workflow/workflows-summary-configurable-table/table-row.svelte @@ -87,11 +87,8 @@ {/if} - {:else} - {/if} - diff --git a/src/lib/holocene/checkbox.svelte b/src/lib/holocene/checkbox.svelte index 435052b3d..69f831fe2 100644 --- a/src/lib/holocene/checkbox.svelte +++ b/src/lib/holocene/checkbox.svelte @@ -113,7 +113,6 @@ 'w-4', 'flex-none', 'cursor-pointer', - 'rounded-md', 'border', 'bg-primary', 'text-inverse', diff --git a/src/lib/holocene/chip.svelte b/src/lib/holocene/chip.svelte index f08a4bab9..13bd67162 100644 --- a/src/lib/holocene/chip.svelte +++ b/src/lib/holocene/chip.svelte @@ -36,7 +36,7 @@ diff --git a/src/lib/holocene/input/chip-input.svelte b/src/lib/holocene/input/chip-input.svelte index d2aadaaf3..cf4cafa41 100644 --- a/src/lib/holocene/input/chip-input.svelte +++ b/src/lib/holocene/input/chip-input.svelte @@ -18,8 +18,6 @@ export let hintText = ''; export let validator: (value: string) => boolean = () => true; export let removeChipButtonLabel: string | ((chipValue: string) => string); - export let unroundRight = false; - export let unroundLeft = false; export let external = false; const values = writable(chips); @@ -111,12 +109,10 @@
{#if $values.length > 0 && !external} {#each $values as chip, i (`${chip}-${i}`)} @@ -173,10 +169,6 @@
diff --git a/src/lib/holocene/input/range-input.svelte b/src/lib/holocene/input/range-input.svelte index c48e4745d..36a81efd8 100644 --- a/src/lib/holocene/input/range-input.svelte +++ b/src/lib/holocene/input/range-input.svelte @@ -124,7 +124,7 @@ } .numeric-input { - @apply h-10 w-10 rounded-lg border border-subtle bg-information text-center text-sm focus-within:outline-none focus-within:ring-2 focus-within:ring-primary/70; + @apply h-10 w-10 border border-subtle bg-information text-center text-sm focus-within:outline-none focus-within:ring-2 focus-within:ring-primary/70; appearance: textfield; } diff --git a/src/lib/holocene/keyboard-shortcut/shortcut.svelte b/src/lib/holocene/keyboard-shortcut/shortcut.svelte index 950aca116..a1b9004b4 100644 --- a/src/lib/holocene/keyboard-shortcut/shortcut.svelte +++ b/src/lib/holocene/keyboard-shortcut/shortcut.svelte @@ -30,6 +30,6 @@ diff --git a/src/lib/holocene/link.svelte b/src/lib/holocene/link.svelte index adc2c3ad7..536f31e3d 100644 --- a/src/lib/holocene/link.svelte +++ b/src/lib/holocene/link.svelte @@ -59,7 +59,7 @@ diff --git a/src/lib/holocene/orderable-list/orderable-list.svelte b/src/lib/holocene/orderable-list/orderable-list.svelte index a4ce00282..705918df0 100644 --- a/src/lib/holocene/orderable-list/orderable-list.svelte +++ b/src/lib/holocene/orderable-list/orderable-list.svelte @@ -19,6 +19,6 @@ } .orderable-list { - @apply surface-primary rounded-lg border border-subtle; + @apply surface-primary border border-subtle; } diff --git a/src/lib/holocene/select/simple-select.svelte b/src/lib/holocene/select/simple-select.svelte index 23aff01cc..a89dc6a5a 100644 --- a/src/lib/holocene/select/simple-select.svelte +++ b/src/lib/holocene/select/simple-select.svelte @@ -33,10 +33,7 @@
- diff --git a/src/lib/holocene/table/table-row.svelte b/src/lib/holocene/table/table-row.svelte index f6837226e..b3dc1a7c6 100644 --- a/src/lib/holocene/table/table-row.svelte +++ b/src/lib/holocene/table/table-row.svelte @@ -10,7 +10,5 @@ - diff --git a/src/lib/holocene/table/table.svelte b/src/lib/holocene/table/table.svelte index 1e614123b..bdcd13c26 100644 --- a/src/lib/holocene/table/table.svelte +++ b/src/lib/holocene/table/table.svelte @@ -45,7 +45,7 @@ } table.fancy { - @apply surface-primary border-separate border-spacing-0 rounded-xl border border-table; + @apply surface-primary border-separate border-spacing-0 border border-table; thead { @apply surface-table; @@ -58,11 +58,11 @@ @apply border-t border-table px-1 py-2; &:first-child { - @apply w-[1px] rounded-tl-lg border-l border-table; + @apply border-l border-table; } &:last-child { - @apply w-[1px] rounded-tr-lg border-r border-table; + @apply border-r border-table; } } } @@ -71,45 +71,9 @@ td { @apply border-t border-table px-1 py-2 text-sm; - &:first-child { - @apply px-1; - } - &:first-child:is(.expanded-cell) { @apply px-0; } - - &:last-child { - @apply w-0 p-0; - } - } - - &:last-child { - td { - &:first-child { - @apply rounded-bl-lg; - } - - &:last-child { - @apply rounded-br-xl; - } - } - } - - tbody :global { - td { - &:first-child { - &:first-child { - @apply rounded-bl-none; - } - } - - &:last-child { - &:last-child { - @apply rounded-br-none; - } - } - } } } } diff --git a/src/lib/holocene/textarea.svelte b/src/lib/holocene/textarea.svelte index 173a13368..2b13fd410 100644 --- a/src/lib/holocene/textarea.svelte +++ b/src/lib/holocene/textarea.svelte @@ -46,7 +46,7 @@ {/if}
diff --git a/src/lib/holocene/tooltip.svelte b/src/lib/holocene/tooltip.svelte index e1d4b01c2..b63357763 100644 --- a/src/lib/holocene/tooltip.svelte +++ b/src/lib/holocene/tooltip.svelte @@ -91,7 +91,7 @@ class:topLeft style={width ? `white-space: pre-wrap; width: ${width}px;` : null} > -
+
{#if icon}{/if} diff --git a/src/lib/holocene/user-menu.svelte b/src/lib/holocene/user-menu.svelte index 842d21ba0..88fdb3081 100644 --- a/src/lib/holocene/user-menu.svelte +++ b/src/lib/holocene/user-menu.svelte @@ -25,12 +25,12 @@ {$authUser?.profile
{#if $authUser?.name} diff --git a/src/lib/layouts/workflow-header.svelte b/src/lib/layouts/workflow-header.svelte index 748b3fdf8..d98e09a22 100644 --- a/src/lib/layouts/workflow-header.svelte +++ b/src/lib/layouts/workflow-header.svelte @@ -97,7 +97,7 @@ {/if}
-
+
@@ -143,10 +143,7 @@ {/if} {#if currentDetails} -
+
-
+

UUID: {endpoint.id}

-
+

Target

diff --git a/src/lib/pages/nexus-endpoints.svelte b/src/lib/pages/nexus-endpoints.svelte index 876d9f63c..83adb80ae 100644 --- a/src/lib/pages/nexus-endpoints.svelte +++ b/src/lib/pages/nexus-endpoints.svelte @@ -77,7 +77,7 @@ {#each endpoints as endpoint}

{endpoint.spec.name} diff --git a/src/lib/vendor/codemirror/theme.ts b/src/lib/vendor/codemirror/theme.ts index dc0c735f0..0dc5fde8a 100644 --- a/src/lib/vendor/codemirror/theme.ts +++ b/src/lib/vendor/codemirror/theme.ts @@ -17,7 +17,6 @@ export const TEMPORAL_THEME = ({ '&': { color: css('--color-text-primary'), backgroundColor: css('--color-surface-primary'), - borderRadius: '0.25rem', borderWidth: '1px', borderColor: css('--color-border-subtle'), padding: '0.5rem', diff --git a/src/routes/(app)/select-namespace/+page.svelte b/src/routes/(app)/select-namespace/+page.svelte index 77ad3cfbe..3442ba9de 100644 --- a/src/routes/(app)/select-namespace/+page.svelte +++ b/src/routes/(app)/select-namespace/+page.svelte @@ -64,16 +64,14 @@ />
{#if items.length} diff --git a/src/routes/(login)/login/+page.svelte b/src/routes/(login)/login/+page.svelte index 6c80700e8..7d6d19b0d 100644 --- a/src/routes/(login)/login/+page.svelte +++ b/src/routes/(login)/login/+page.svelte @@ -47,9 +47,7 @@ {#if error}
-

+

{error}

diff --git a/src/routes/(login)/signin/+page.svelte b/src/routes/(login)/signin/+page.svelte index 6c80700e8..7d6d19b0d 100644 --- a/src/routes/(login)/signin/+page.svelte +++ b/src/routes/(login)/signin/+page.svelte @@ -47,9 +47,7 @@ {#if error}
-

+

{error}

{:else}
+
-
-