Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's up with the GTK2 build time dep for Electron? #37

Closed
severen opened this issue Aug 14, 2016 · 2 comments
Closed

What's up with the GTK2 build time dep for Electron? #37

severen opened this issue Aug 14, 2016 · 2 comments

Comments

@severen
Copy link

severen commented Aug 14, 2016

I was looking at the Electron PKGBUILD and noticed that it has a makedepend on GTK2, despite the fact that it's apparently built with GTK3 support now as of #10 and has a runtime dependency on GTK3.

Is this an error or is it some intricacy of Electron?

@tensor5
Copy link
Owner

tensor5 commented Aug 14, 2016

Right now Electron has no runtime or buildtime dependency on GTK2, however during the initial stage of the build process the Chromium part of the build does pkg-config gtk-2.0; rather than patching Chromium I opted for including gtk2 in makedepends.

@severen
Copy link
Author

severen commented Aug 14, 2016

I see now, thanks for the clarification.

@tensor5 tensor5 closed this as completed Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants