Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdaBelief optimizer #2234

Closed
wants to merge 5 commits into from
Closed

Conversation

cryu854
Copy link

@cryu854 cryu854 commented Nov 9, 2020

Description

Fixes #2203 by adding AdaBelief optimizer. Project page, arXiv, GitHub

Although @juntang-zhuang has an official implementation at juntang-zhuang/Adabelief-Optimizer, but it was heavily based on tensorflow_addons/optimizers/rectified_adam.py, and we only modified the core algorithm part.

So we decided to contribute this optimizer to leverage the friendly API from addons, with the hope that it can help anyone who is struggling for training a neural network.

Type of change

Checklist:

How Has This Been Tested?

Unit tests for AdaBelief, the results are compared with numpy update using the same algorithm.

@bhack
Copy link
Contributor

bhack commented Nov 10, 2020

I think It is a little bit early for this. See #2194

@cryu854
Copy link
Author

cryu854 commented Nov 11, 2020

Thank you for your feedback. I think AdaBelief would be a good choice for training because it uses curvature information like an ideal optimizer, which makes it more intuitively reasonable. Once addons decides to add this feature, I will help maintain it.

@bhack
Copy link
Contributor

bhack commented Nov 11, 2020

Is that currently we have just a single citation #2203 (comment)

@dathudeptrai
Copy link

@bhack @cryu854 will it merge ?

@cryu854
Copy link
Author

cryu854 commented Dec 4, 2020

@dathudeptrai I think it depends on the usage rate by community and the number of citations. Currently, please use juntang-zhuang/Adabelief-Optimizer.

@denadai2
Copy link
Contributor

isn't this done?

@bhack
Copy link
Contributor

bhack commented May 20, 2022

Yes

@bhack bhack closed this May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AdaBelief optimizer [https://arxiv.org/abs/2010.07468]
4 participants