Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor tools for PARAFAC2 #21

Open
cchatzis opened this issue Jul 4, 2024 · 2 comments
Open

Factor tools for PARAFAC2 #21

cchatzis opened this issue Jul 4, 2024 · 2 comments

Comments

@cchatzis
Copy link

cchatzis commented Jul 4, 2024

Hi there, thank you making my life easier with tlviz. I was wondering, would there be interest in updates of functions in factor_tools.py to support PARAFAC2Tensors?

@yngvem
Copy link
Collaborator

yngvem commented Jul 29, 2024

Hi @cchatzis, thank you for the kind feedback! 😄

When we created TLViz, Marie and I explicitly made the choice to focus on PARAFAC (and small amount of Tucker) to keep the scope and matinainer work low. However, we also did our best to keep it general enough to make it possible to use TLViz with other decompositions.

We don't have any examples showcasing this in the example gallery though, so one thing that would be very valuable is an example for the gallery that demonstrates how to turn PARAFAC2Tensor into a "CPTensor" form to use the functions in factor_tools for evaluating them. Maybe even how to use multimodal_evaluation with custom similarity metrics and error functions.

@cchatzis
Copy link
Author

@yngvem I currently work mainly with PARAFAC2Tensors and tlviz, so I definetely see the value in that. Expect a PR in the future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants