Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AsmState for printing debug string IR #2159

Open
nsmithtt opened this issue Feb 10, 2025 · 3 comments
Open

Use AsmState for printing debug string IR #2159

nsmithtt opened this issue Feb 10, 2025 · 3 comments
Assignees
@azecevicTT

Comments

@nsmithtt
Copy link
Contributor

nsmithtt commented Feb 10, 2025 •
edited
Loading

As follow on to the excellent find as part of this PR:

We can further optimize IR printing by using AsmState.
@nsmithtt nsmithtt changed the title Use [AsmState](https://mlir.llvm.org/doxygen/classmlir_1_1AsmState.html) for printing debug string IR Use AsmState for printing debug string IR Feb 10, 2025
@nsmithtt nsmithtt mentioned this issue Feb 10, 2025
Merged
1 task
@nsmithtt
Copy link
Contributor Author

FYI @azecevicTT

@azecevicTT
Copy link
Contributor

This looks really promising for our use case.

@azecevicTT
Copy link
Contributor

Yeah, @nsmithtt this is fantastic, debug printing is a non-issue even for the very large input. Turns out that verification is also a non-issue in this case since it's done only once at the top level. diff also confirms there is no difference in the output with AsmState and without it.

@azecevicTT azecevicTT self-assigned this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azecevicTT azecevicTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nsmithtt @azecevicTT