[bug] Fix Flaky Test in test/sample_random/processor-spec.ts #988
Labels
Comments
|
It looks like an off by one error in the processor's call to |
godber
pushed a commit
that referenced
this issue
Jan 17, 2025
This PR makes the following changes: - Fixes a bug in the `sample_random` processor when `probability_to_keep` is set to 0%. If the random number generator returns 0 then a record would be returned ( 0 <= 0 is true ). Setting the `random()` function's minimum value to 1 ensures that no records will ever be returned ( 1 <= 0 is false). - Update docs - Add test with large dataset and `probability_to_keep` set to 0% - bump standard asset from v1.3.1 to v1.3.2 ref: #988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We've noticed a test in
test/sample_random/processor-spec.tsthats been very flaky lately and happens more often then we'd like. Here is a failed pipeline:https://github.com/terascope/standard-assets/actions/runs/12832375172/job/35785011148
It should return no data but instead returns 1 somehow. This could be a change to a dependency with different behavior or some sort of race condition.
The text was updated successfully, but these errors were encountered: