Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoverMany and Hover don't actually hover #59

Open
Munksgaard opened this issue Nov 21, 2018 · 6 comments
Open

HoverMany and Hover don't actually hover #59

Munksgaard opened this issue Nov 21, 2018 · 6 comments

Comments

@Munksgaard
Copy link

Ellie link

I've tried to port the first example from the old version to 0.19, but the hoverMany function seems to work differently from what it did back then. I would expect hoverMany to create a little box next to the cursor or the actual point in question, but instead it seems like a box is added at the bottom of the chart. The same happens if I try to use hover

Am I missing something?

@yuzisee
Copy link

yuzisee commented Jan 1, 2019

Apparently a typo (created during migration to 0.19?) introduced on Oct 27, 2018

a92d43d#r31813341

@Munksgaard
Copy link
Author

Certainly looks like it.

Munksgaard added a commit to Munksgaard/line-charts that referenced this issue Feb 1, 2019
According to the conversation in terezka#59, we should probably be using `containerStyles` here.

Hopefully, this fixes terezka#59
@jartsap
Copy link

jartsap commented Feb 26, 2019

Hi, is there any hope that this would be fixed in near future?

@LiberalArtist
Copy link

I believe this is fixed by #58, which was merged recently, but there isn't a new version on https://package.elm-lang.org yet.

@QuinnFreedman
Copy link

I can confirm that I am still getting this error in 2.0.0 (the current version on package.elm-lang.org) and it's causing me a lot of trouble.

Is there any chance of getting a new package version with this fix?

@LiberalArtist
Copy link

I've vendored this package in as a Git submodule to get the fix from #58, and I can report that it's working great for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants