Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalSwitcher === null, Parcel never sealed on custom Gateway #348

Closed
xprojects-de opened this issue Jul 3, 2024 · 2 comments · Fixed by #349
Closed

LocalSwitcher === null, Parcel never sealed on custom Gateway #348

xprojects-de opened this issue Jul 3, 2024 · 2 comments · Fixed by #349

Comments

@xprojects-de
Copy link

xprojects-de commented Jul 3, 2024

NC 2.0.10 under C 4.13 (2.0.9 is working)

Using Contao 4.13 (Symfony 5.4) and customGateway under NC 2.0.10 the LocalSwitcher is null:

if ($parcel->isSealed() || null === $this->localeSwitcher) {

So the Parcel is never sealed and there is an Exception:

[2024-07-03T19:44:40.217401+02:00] contao.error.ERROR: The parcel did not contain all required stamps. Provided: [Terminal42\NotificationCenterBundle\Parcel\Stamp\NotificationConfigStamp, Terminal42\NotificationCenterBundle\Parcel\Stamp\TokenCollectionStamp, Terminal42\NotificationCenterBundle\Parcel\Stamp\GatewayConfigStamp, Terminal42\NotificationCenterBundle\Parcel\Stamp\LanguageConfigStamp, Alpdesk\AlpdeskBooking\Library\Notifications\AlpdeskBookingGatewayConfigStamp], Required: [Alpdesk\AlpdeskBooking\Library\Notifications\AlpdeskEmailStamp]. {"exception":"[object] (Terminal42\\NotificationCenterBundle\\Exception\\Parcel\\CouldNotDeliverParcelException(code: 0): The parcel did not contain all required stamps. Provided: [Terminal42\\NotificationCenterBundle\\Parcel\\Stamp\\NotificationConfigStamp, Terminal42\\NotificationCenterBundle\\Parcel\\Stamp\\TokenCollectionStamp, Terminal42\\NotificationCenterBundle\\Parcel\\Stamp\\GatewayConfigStamp, Terminal42\\NotificationCenterBundle\\Parcel\\Stamp\\LanguageConfigStamp, Alpdesk\\AlpdeskBooking\\Library\\Notifications\\AlpdeskBookingGatewayConfigStamp], Required: [Alpdesk\\AlpdeskBooking\\Library\\Notifications\\AlpdeskEmailStamp]

I think the Parcel must be sealed also when LocalSwitcher is null.

@Toflar
Copy link
Member

Toflar commented Jul 5, 2024

Can you check if #349 fixes the issue? Sorry, I have no more projects running 4.13 so I usually don't notice issues with v4 anymore 😇

@xprojects-de
Copy link
Author

@Toflar Thanks. Working fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants