Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vkcube framerate in latest version of termux-x11 #774

Closed
hansm629 opened this issue Dec 24, 2024 · 14 comments
Closed

vkcube framerate in latest version of termux-x11 #774

hansm629 opened this issue Dec 24, 2024 · 14 comments

Comments

@hansm629
Copy link

hansm629 commented Dec 24, 2024

Problem description

The latest version of Termux-X11 has fixed all X11 server performance issues on Samsung Exynos devices using ANGLE EGL.

However, when running vkcube,
I noticed that it is showing an abnormally fast frame rate.

It is the same frame rate as when I added the MESA_VK_WSI_PRESENT_MODE=mailbox environment variable and ran it.

Is this the intended behavior?

If it is the intended behavior,
Is there an environment variable or option that can make it show the normal frame rate as before?

What steps will reproduce the bug?

2024_12_25.03_18.mp4

What is the expected behavior?

No response

@twaik
Copy link
Member

twaik commented Dec 24, 2024

Can I please ask you to check which commit causes this? I mean checking artifacts in Actions tab.

@hansm629
Copy link
Author

@twaik
https://github.com/termux/termux-x11/actions/runs/12476603692

I installed and tested the above version.

@twaik
Copy link
Member

twaik commented Dec 24, 2024

It is the latest available version.
It does not clarify which commit causes it.

@hansm629
Copy link
Author

@twaik
Sorry.
I didn't understand correctly.

How can I explain it to you?

If you tell me the procedure, I will comment right away.

@twaik
Copy link
Member

twaik commented Dec 24, 2024

I mean can you please check CI runs one by one in chronological order (probably starting with the artifact from two weeks ago) and tell me when the problem starts to be reproducible?

@hansm629
Copy link
Author

@twaik
Oh! I understand now.
I will comment on which build the symptom occurred in after testing.

Please wait a moment.

@hansm629
Copy link
Author

@twaik
I Found it!

The symptom occurs starting from the build below!

https://github.com/termux/termux-x11/actions/runs/12471770069

@twaik
Copy link
Member

twaik commented Dec 24, 2024

It is sad. This commit fixes mesa and angle frame sync.
I will take a look at it later.
Can you please tell what vulkan implementation you use, where you got it (this exact version) and point to the source code of it?

@hansm629
Copy link
Author

@twaik
termux/termux-packages#22500

Tested on the latest build of mesa-vulkan-icd-wrapper, which is currently a pull request.

@twaik
Copy link
Member

twaik commented Dec 29, 2024

@xMeM can you please take a look at what exactly may go wrong?

@xMeM
Copy link
Contributor

xMeM commented Dec 29, 2024


It should be Success instead of TRUE

@twaik
Copy link
Member

twaik commented Dec 29, 2024

You are right. I do not know how I missed it.
Fixed by 0f95b02.

@twaik twaik closed this as completed Dec 29, 2024
@hansm629
Copy link
Author

@twaik
Thank you! It's fixed!
And vkmark results are great too!

X11 Server on Xclipse series GPU is now perfect!

2024_12_30.22_06.mp4
~$ vkmark
=======================================================
    vkmark 2017.08
=======================================================
    Vendor ID:      0x144D
    Device ID:      0x2600200
    Device Name:    Samsung Xclipse 940
    Driver Version: 8388608
    Device UUID:    35f18c726c2d5685ae5893b649517b92
=======================================================
[vertex] device-local=true: FPS: 5058 FrameTime: 0.198 ms
[vertex] device-local=false: FPS: 5289 FrameTime: 0.189 ms
[texture] anisotropy=0: FPS: 4952 FrameTime: 0.202 ms
[texture] anisotropy=16: FPS: 4858 FrameTime: 0.206 ms
[shading] shading=gouraud: FPS: 4877 FrameTime: 0.205 ms
[shading] shading=blinn-phong-inf: FPS: 4896 FrameTime: 0.204 ms
[shading] shading=phong: FPS: 4726 FrameTime: 0.212 ms
[shading] shading=cel: FPS: 4513 FrameTime: 0.222 ms
[effect2d] kernel=edge: FPS: 4167 FrameTime: 0.240 ms
[effect2d] kernel=blur: FPS: 3093 FrameTime: 0.323 ms
[desktop] <default>: FPS: 2321 FrameTime: 0.431 ms
[cube] <default>: FPS: 3751 FrameTime: 0.267 ms
[clear] <default>: FPS: 4202 FrameTime: 0.238 ms
=======================================================
                                   vkmark Score: 4361
=======================================================

@twaik
Copy link
Member

twaik commented Dec 30, 2024

High result is probably because of dropping the frames which are not going to be displayed. So the driver works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants