Update doc build to py313 #2050
Open
+34
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opotowsky
added
documentation
opotowsky
commented
Jan 10, 2025
opotowsky
commented
Jan 10, 2025
|
was just talking to @john-science about the nbextensions. That's from back when we had an awesome dockerized jupyterhub instance of ARMI with all plugins. It added a few neat tools that some users liked. It's totally fine to remove it now since we don't know of anyone using them in jupyterhub at the moment. |
john-science
approved these changes
Feb 3, 2025
|
Okay, so I opened the docs your PR generates: https://github.com/terrapower/armi/actions/runs/13082534763?pr=2050 Almost everything is working, and looks great. But the "Gallery" section is broken:
There are no links to the generated pages. I downloaded another PRs recently generated docs and they did not have this problem. @ntouran Could this be the dependency we dropped? |
opotowsky
commented
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
The docs are being built with python 3.9. This updates them to python 3.13 (updating dependency pins in the process)
Why is the change being made?
Keepin' up with the times!
Checklist
docfolder.pyproject.toml.