-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing function WithDockerCompose
#122
Comments
Hi @SbiCA, a great feature for sure. I think This week I would like to improve some small parts in the build pipeline and add another section to the README.md about your issue #120. Next week I’m busy, but I could start working on this feature the following week. Of course, your help is always welcome! If you like, just go ahead and start with a feature branch - or we'll work together on this feature. What do you think? |
@HofmeisterAn sure I would be open for collaboration, since I'm in a similar situation regarding my availability. Maybe we could have a gitter or slack channel for that purpose or what would be your favorite way of having design discussions? |
WithDockerCompose
WithDockerCompose
Gitter, Slack or MS Teams would be nice. I'm using all three of them. Anything you prefer? As soon as I’m back next week we can start having design discussions. |
@SbiCA I think it would be great if you join the official Slack channel: http://slack.testcontainers.org/. |
Waiting for this feature too! |
I agree, this feature would be great. Maybe you can get in touch with @SbiCA. A pull request is more than welcome. I am happy to help as much as I can, like feature discussions, tests, code reviews, etc. I just can’t bring myself to do all the development now, due other projects. |
Same here 😢 , sorry for having raised the expectations/adding delay here. |
Any way to join? |
I think no one started yet. Would you like to start? Maybe some more will join than. |
I'd be happy to help, is anyone working on it? |
I think no one is working on it right now. Contribution is more than welcome. |
Cool, I'll give it a shot. |
Thinking about the API design for this, I have a few points to raise:
|
It would be nice to consider the testcontainers-java implementation. I'm not very familiar with it, but I think it is a good idea not to differentiate too much. OC, it should still be idiomatic with .NET. |
The java implementation is spinning a container to run |
May I ask how do you plan on implementing this? https://github.com/mariotoffia/FluentDocker seems neatly implemented. Are you on official slack? @LoremFooBar |
Basically by running |
what about running these tests as part of the CI pipeline for example? |
I find it reasonable to have the developer properly set up a CI environment for their needs, and that includes any binaries required to run their tests. We can ensure a clear error message is displayed when |
Any news about it? |
Unfortunately, I was not able to make much progress eventually. |
Still working on this feature? Currently this is the only feature that still makes us use FluentDocker instead of TestContainers... |
I think nobody is working on the Compose support right now. |
Hi @HofmeisterAn |
is this feature any closer to being merged? See here for more information. Thanks, |
I came across this issue today after being a bit perplexed by the idea of a "Docker Wormhole Configuration" It feels like a bit of an anti-pattern, and possibly a security concern. In the event that a container is compromised, am I correct in concluding that there is an easy path to instructing the docker daemon to start other containers of any image on the host? Further reference: https://ro14nd.de/Docker-Wormhole-Pattern
|
Hey! |
I reviewed the pull request (#1082) some time ago and have a few suggestions and things I would like to discuss first (nkz-soft#1) before merging the feature and bringing it upstream. |
Hi! How this is going? I'm really want to use it. |
Is your feature request related to a problem? Please describe.
I love the approach of having a single container scenario for a test case but there are also scenarios where I'd like to spin up a whole set of containers and therefore use docker-compose as declaration.
Describe the solution you'd like
I'd like to spin up a set of containers by specifying a
docker-compose.yml
similar to the Java version https://www.testcontainers.org/modules/docker_compose/Describe alternatives you've considered
Not sure If there is one
docker-compose.yml
will also be used to deploy the application under test this would be strange.Additional context
Also other library authors could benefit from such an approach, I happen to know that https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks is using compose and I think it would be great improvement on there development experience (since you don' t have to remember starting the containers in advance ;) )
Cheers & let me know what you think of the idea
The text was updated successfully, but these errors were encountered: