Improve Oracle support #1321
Open
Improve Oracle support #1321
+89
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Use the correct database default name depending on the Docker image version and enable setting a custom database name for Oracle 18 and onwards. Fixes testcontainers#1233
0xced
force-pushed
the
feature/oracle-all-versions
branch
from
0ade2f4 to
84f5181
Compare
|
11 Oracle containers from 4 images and the GitHub runner fails with No space left on device 😖 |
It looks like we are right at the edge. Although I expected ~20GB to be enough, I thought the root filesystem had something like ~30GB left. Maybe we can save some MBs by restoring the NuGet cache on the temp disk, but that likely won't be enough too. What do you think about removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request selects the correct database default name depending on the Docker image version and enable setting a custom database name for Oracle 18 and onwards.
Why is it important?
This enables using the new Oracle Docker images (e.g. gvenzl/oracle-free) which doesn't work with the current implementation because of the hardcoded
XEPDB1default database.Note
The
gvenzl/oracle-freeimage is the first one with arm64 support which is especially interesting for macOS users.Related issues
Closes #1233
How to test this PR
The
OracleContainerTestclass has been augmented to test many variations of the Oracle Docker images.