Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TESTCONTAINERS_HOST_OVERRIDE is not working #2609

Closed
emfomy opened this issue Jun 27, 2024 · 4 comments
Closed

[Bug]: TESTCONTAINERS_HOST_OVERRIDE is not working #2609

emfomy opened this issue Jun 27, 2024 · 4 comments
Labels
bug An issue with the library

Comments

@emfomy
Copy link

emfomy commented Jun 27, 2024

Testcontainers version

0.31.0

Using the latest Testcontainers version?

Yes

Host OS

N/A

Host arch

N/A

Go version

N/A

Docker version

N/A

Docker info

N/A

What happened?

According to https://golang.testcontainers.org/system_requirements/rancher/ and https://golang.testcontainers.org/features/configuration/, we should be able to use TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE and TESTCONTAINERS_HOST_OVERRIDE.

However, these environment variables are not parsed in https://github.com/testcontainers/testcontainers-go/blob/v0.31.0/internal/config/config.go#L69

Relevant log output

No response

Additional information

No response

@emfomy emfomy added the bug An issue with the library label Jun 27, 2024
@mdelapenya
Copy link
Member

Hi @emfomy thanks for opening this issue. Just to let you know, there is an ongoing PR addressing this: #2609

@stevenh
Copy link
Collaborator

stevenh commented Aug 8, 2024

This is fixed by two different pending PR's #2661 and #2725

@mdelapenya
Copy link
Member

@emfomy could you verify if the current HEAD main resolved this issues? Thanks!

@emfomy
Copy link
Author

emfomy commented Aug 20, 2024

It does solve the issue! Thanks!

@emfomy emfomy closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the library
Projects
None yet
Development

No branches or pull requests

3 participants