Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): login on Docker hub #2704

Closed
wants to merge 1 commit into from

Conversation

mdelapenya
Copy link
Member

What does this PR do?

It uses https://github.com/docker/login-action to login to Docker Hub.

Why is it important?

Do not hit pull rate limits, and identify our builds.

@mdelapenya mdelapenya requested a review from a team as a code owner August 8, 2024 12:35
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 8, 2024
@mdelapenya mdelapenya self-assigned this Aug 8, 2024
Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit a25e3cc
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66b4bb7f8920d200077327db
😎 Deploy Preview https://deploy-preview-2704--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and is really quite a pain when tests run for ages then fail towards the end due to this.

Obviously needs the secret configuring on the repo so it works.

@mdelapenya mdelapenya marked this pull request as draft August 12, 2024 09:48
@mdelapenya
Copy link
Member Author

Closing as not needed, at the same time, it would cause all PRs to fail because of the secret

@mdelapenya mdelapenya closed this Aug 13, 2024
@mdelapenya mdelapenya deleted the docker-login branch August 13, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants