Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Upgrade dependency 'milvus-io/milvus-sdk-go'. #2751

Closed
HappyHacker123 opened this issue Aug 27, 2024 · 3 comments
Closed

[Enhancement]: Upgrade dependency 'milvus-io/milvus-sdk-go'. #2751

HappyHacker123 opened this issue Aug 27, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@HappyHacker123
Copy link
Contributor

HappyHacker123 commented Aug 27, 2024

Proposal

Upgrade dependency 'milvus-io/[email protected]'.

Problem Description

Currently testcontainters-go depends on milvus-io/[email protected]. However, milvus-io/milvus-sdk-go seems to change the retag v2.3.6, so the checksum from the code in github does not match the checksum saved in sum.golang.org.

Consequently, when trying to download milvus-io/[email protected] directly from Github, the following error will occur.

root@iZj6c5flh0q5ax3d1ttfuhZ:~/temp# GOPROXY=direct go get github.com/milvus-io/milvus-sdk-go/v2/@v2.3.6
go: downloading github.com/milvus-io/milvus-sdk-go/v2 v2.3.6
go: github.com/milvus-io/milvus-sdk-go/[email protected]: verifying module: checksum mismatch
        downloaded: h1:pPbasW7GauN6ZvJhpKdbyW5uqU7/b61fxvRqDHDho14=
        sum.golang.org: h1:JVn9OdaronLGmtpxvamQf523mtn3Z/CRxkSZCMWutV4=

SECURITY ERROR
This download does NOT match the one reported by the checksum server.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

Solution

Upgrade milvus-io/milvus-sdk-go to avoid this problem.

@HappyHacker123 HappyHacker123 added the enhancement New feature or request label Aug 27, 2024
@mdelapenya
Copy link
Member

Hi @HappyHacker123 would you be interested in working on the fix? Feel free to submit a PR to the milvus module if possible 🙏

Thanks!

@HappyHacker123
Copy link
Contributor Author

@mdelapenya Thanks for your reply! I have raised a pr for this.

@mdelapenya
Copy link
Member

Closing as fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants