Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace 'assert' with 'require' #2826

Closed

Conversation

JoelLau
Copy link
Contributor

@JoelLau JoelLau commented Oct 16, 2024

ran through the codebase - these should be the last changes required for the raised issues!

What does this PR do?

  • use require wherever possible

Why is it important?

  • reduce noise in tests by failing early

Related issues

@JoelLau JoelLau requested a review from a team as a code owner October 16, 2024 14:02
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 41b36f2
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/670fc76f81a05b000827ae32
😎 Deploy Preview https://deploy-preview-2826--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoelLau JoelLau closed this Oct 16, 2024
@JoelLau
Copy link
Contributor Author

JoelLau commented Oct 16, 2024

wrong branch name - closing in favour of #2827

@JoelLau JoelLau deleted the chore/2822/use-testify-require branch October 16, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: use testify's require instead of assert.
1 participant