chore: provide an internal tools module #2922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Matthieu MOREL <[email protected]>
|
Is this impacted by the impending tools addition to golang as detailed here? |
|
It's probably better to wait for this feature as the v2 of mockery it getting in the way of the script here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provides an internal tools module that isolates tools in a dedicated folder (.tools) at the root of the folder instead of using local GOBIN
Why is it important?
This helps sharing the same versions for tools between developers. It also allow to use dependencies managers to provide updates on those tools.
This is inspired by the work done on opentelemetry-collector