-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EventStoreDB module #894
Conversation
I've copied the description from https://testcontainers.com/modules/mockserve/
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Does EventStoreDB still exist? https://www.kurrent.io/blog/kurrent-re-brand-faq
|
Hey, I still call it EventStoreDb by habit, but I can rename the package to Kurrent. |
I think that would be appropriate, given that the rebranding happened last November |
We're talking 2 months ago. Even the official NPM package and Docker image haven't rebranded yet. I'd suggest waiting until that's done to avoid confusion ( |
So the PR stays open until the docker image and npm package are rebranded? |
That's what I'd suggest. If people are still going to DockerHub and NPM and searching for Eventstore then it makes sense to call the Testcontainers module Eventstore. When that changes we'll change. I don't see any benefit in being the first to rename it, IMO it just adds confusion as you have a mismatch of the TC module name, and the underlying image/NPM lib. |
The eventstore.com URL on the Testcontainers page is redirected to kurrent.io https://github.com/testcontainers/testcontainers-node/blob/main/docs/modules/eventstoredb.md This was alarming/confusing to me because you have to scroll down to find a mention of the former Event Store name. I think it would be helpful and avoid confusion to mention the rebrand and update the URL to its current address. For example: EventStoreDB (rebranding to KurrentDB) is an event sourcing database that stores data in streams of immutable events. |
This PR adds an EventStoreDB module, the implementation is similar to the dotnet implementation.