Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventStoreDB module #894

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Add EventStoreDB module #894

merged 10 commits into from
Jan 13, 2025

Conversation

botflux
Copy link
Contributor

@botflux botflux commented Jan 12, 2025

This PR adds an EventStoreDB module, the implementation is similar to the dotnet implementation.

Copy link

netlify bot commented Jan 12, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit d2228bf
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/6783d305f77a09000892fc5c
😎 Deploy Preview https://deploy-preview-894--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels Jan 12, 2025
@cristianrgreco cristianrgreco merged commit efe3426 into testcontainers:main Jan 13, 2025
179 checks passed
@joebowbeer
Copy link
Contributor

Does EventStoreDB still exist?

https://www.kurrent.io/blog/kurrent-re-brand-faq

Event Store – the company and the product – are rebranding as Kurrent.

  • The flagship product will be referred to as “the Kurrent event-native data platform” or “the Kurrent platform” or simply “Kurrent"
  • EventStoreDB will be referred to as KurrentDB
  • Event Store Cloud will now be called Kurrent Cloud

@botflux
Copy link
Contributor Author

botflux commented Jan 21, 2025

Hey, I still call it EventStoreDb by habit, but I can rename the package to Kurrent.

@joebowbeer
Copy link
Contributor

Hey, I still call it EventStoreDb by habit, but I can rename the package to Kurrent.

I think that would be appropriate, given that the rebranding happened last November

@cristianrgreco
Copy link
Collaborator

cristianrgreco commented Jan 22, 2025

given that the rebranding happened last November

We're talking 2 months ago. Even the official NPM package and Docker image haven't rebranded yet. I'd suggest waiting until that's done to avoid confusion (new KurrentContainer("eventstore/eventstore"))

@botflux
Copy link
Contributor Author

botflux commented Jan 22, 2025

So the PR stays open until the docker image and npm package are rebranded?

@cristianrgreco
Copy link
Collaborator

cristianrgreco commented Jan 22, 2025

That's what I'd suggest. If people are still going to DockerHub and NPM and searching for Eventstore then it makes sense to call the Testcontainers module Eventstore. When that changes we'll change. I don't see any benefit in being the first to rename it, IMO it just adds confusion as you have a mismatch of the TC module name, and the underlying image/NPM lib.

@joebowbeer
Copy link
Contributor

joebowbeer commented Jan 22, 2025

The eventstore.com URL on the Testcontainers page is redirected to kurrent.io

https://github.com/testcontainers/testcontainers-node/blob/main/docs/modules/eventstoredb.md

This was alarming/confusing to me because you have to scroll down to find a mention of the former Event Store name.

I think it would be helpful and avoid confusion to mention the rebrand and update the URL to its current address.

For example:

EventStoreDB (rebranding to KurrentDB) is an event sourcing database that stores data in streams of immutable events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Backward compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants