Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade jsdom to v21 which still supports Node 14 #584

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Fullchee
Copy link

What:

  • Upgrade jsdom to v21 which still supports Node 14

Why:

How:

Checklist:

  • [ ] Documentation
  • [ ] Tests
  • [ ] Updated Type Definitions
  • Ready to be merged

@Fullchee Fullchee marked this pull request as ready for review February 18, 2024 20:29
@Fullchee
Copy link
Author

@fpapado @gnapse

Do we want to release a new major release of jest-dom@7which still supports Node 14?

We're upgrading jsdom@16 to jsdom@21

  • => 5 breaking changes which might unwittingly break things in this library too

Comment on lines +1 to +3
/**
* @jest-environment node
*/
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolves this issue

I copy pasted from this PR

https://github.com/testing-library/jest-dom/pull/568/files?w=1#diff-aac3f7b77b88910a3cab3e23a102333b446c87359e633f41c0441c7738791d5b

  ● Test suite failed to run

    ReferenceError: TextEncoder is not defined

      1 |
      2 |
    > 3 | import {JSDOM} from 'jsdom'
        | ^
      4 | import {render} from './helpers/test-utils'
      5 |
      6 | /*

@Fullchee Fullchee marked this pull request as draft February 18, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.toHaveStyle() doesn't know about aspect-ratio
1 participant