fix: add a convertCssObject to create a valid style object within the toHaveStyle. #591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
I created convertCssObject that assigns correct properties and values, and called getStyleDeclaration before it.
Why:
In the haveToStyle method, when given a property is in camelCase and the value is a number, there was a bug where incorrect test cases were passing due to internal comparison of empty strings.
so, the following tests pass.
I provided more detailed analysis in a comment on the relevant issue.
How:
When a number is passed as a value, I checked if the property requires the 'px' unit, and if so, appended 'px'. To prevent getPropertyValue function from returning an empty string when encountering camelCase, I converted properties to snake-case, excluding custom properties.
Checklist: