-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "fix: use kotlin compatible getType" #515
Merged
janicduplessis
merged 1 commit into
th3rdwave:main
from
WoLewicki:revert-507-@wolewicki/support-RN-75
Jul 30, 2024
Merged
Revert "fix: use kotlin compatible getType" #515
janicduplessis
merged 1 commit into
th3rdwave:main
from
WoLewicki:revert-507-@wolewicki/support-RN-75
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 05ad6b4.
janicduplessis
approved these changes
Jul 30, 2024
@janicduplessis Can we get a release with this in it? Currently breaking in RN 0.75 |
Breaking build on RN 0.75.1 |
Released! |
This was referenced Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #507 since in the newest RCs we decided to drop the
getType
syntax in favor of the old one, meaning this is no longer necessary.