Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Remove a check that is no longer needed #535

Merged
merged 3 commits into from
Oct 16, 2024

Commits on Oct 11, 2024

  1. Removed a check that is no longer needed

    We've had some issue with monorepos when resolving the codegen config on Android in other libraries, and found that due to versions no longer in use we could now remove the version test in `react-native-config.js` and always return the component descriptor etc.
    
    (The monorepo issue was with using `require.main.require` which will resolve to the calling script and not the module)
    
    For reference, here is the same PR in @react-native-community/slider:
    
    callstack/react-native-slider#657
    chrfalch committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2116a0e View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. cr: Reverted and simplified change after code review

    Removed previous change and made the `supportsCodegenConfig` variable true initially
    chrfalch committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b9434af View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4f8b18a View commit details
    Browse the repository at this point in the history