-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BridgesList Preferences is an overloaded field #133
Comments
sisbell
added a commit
to sisbell/Tor_Onion_Proxy_Library
that referenced
this issue
Oct 21, 2019
Bug 30767: Custom obfs4 bridge does not work on Tor Browser for Android TOPL fixes thaliproject#133 fixes thaliproject#134
sisbell
added a commit
to sisbell/Tor_Onion_Proxy_Library
that referenced
this issue
Nov 1, 2019
Bug 30767: Custom obfs4 bridge does not work on Tor Browser for Android Bug 30552: Android - Clean up torrc TOPL fixes thaliproject#133 fixes thaliproject#134 Bug 30552: Android - Clean up torrc Builder fixes.
sisbell
added a commit
to sisbell/Tor_Onion_Proxy_Library
that referenced
this issue
Nov 1, 2019
Bug 30767: Custom obfs4 bridge does not work on Tor Browser for Android Bug 30552: Android - Clean up torrc TOPL fixes thaliproject#133 fixes thaliproject#134
sisbell
added a commit
to sisbell/Tor_Onion_Proxy_Library
that referenced
this issue
Nov 5, 2019
Bug 30767: Custom obfs4 bridge does not work on Tor Browser for Android Bug 30552: Android - Clean up torrc TOPL fixes thaliproject#133 fixes thaliproject#134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
BridgesList is an overloaded field, which can cause some confusion. The list can be:
For (1), we just pass back all bridges, the filter will occur elsewhere in the library. For (2) we return the bridge list as a raw stream. If length is greater than 5, then we know this is a custom bridge
We should fix this so that we have separate preferences for 1 and 2. We also shouldn't be looking at string length to determine field type.
This tracks with https://trac.torproject.org/projects/tor/ticket/30501
The text was updated successfully, but these errors were encountered: