Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mandatory checkbox in integer question type #44

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Add mandatory checkbox in integer question type #44

merged 4 commits into from
Sep 8, 2023

Conversation

barshathakuri
Copy link
Collaborator

Changes

  • Add mandotary field

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • build works
  • eslint issues
  • typescript issues
  • codegen errors
  • console.log meant for debugging
  • typos
  • unwanted comments
  • conflict markers

This PR contains valid:

  • permission checks

@barshathakuri barshathakuri temporarily deployed to Test September 7, 2023 12:35 — with GitHub Actions Inactive
@barshathakuri barshathakuri marked this pull request as draft September 7, 2023 12:36
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 04:59 — with GitHub Actions Inactive
@barshathakuri barshathakuri marked this pull request as ready for review September 8, 2023 05:00
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:02 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:04 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:12 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:16 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:18 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:21 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:24 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:26 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:29 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:42 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:44 — with GitHub Actions Inactive
subinasr
subinasr requested changes Sep 8, 2023
View reviewed changes
src/views/QuestionnaireEdit/SelectOneQuestionForm/index.tsx Outdated
@@ -55,7 +56,7 @@ const CREATE_SINGLE_SELECTION_QUESTION = gql`
private {
projectScope(pk: $projectId) {
createQuestion(
data: $input,
data: $input,2323
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this number?

@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:51 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 05:53 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 06:46 — with GitHub Actions Inactive
@barshathakuri barshathakuri temporarily deployed to Test September 8, 2023 06:48 — with GitHub Actions Inactive
@subinasr subinasr temporarily deployed to Test September 8, 2023 09:23 — with GitHub Actions Inactive
@subinasr subinasr temporarily deployed to Test September 8, 2023 09:25 — with GitHub Actions Inactive
@subinasr subinasr merged commit 2e0b726 into develop Sep 8, 2023
7 checks passed
@subinasr subinasr deleted the feature/add-mandatory branch September 8, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subinasr subinasr subinasr requested changes

@AdityaKhatri AdityaKhatri Awaiting requested review from AdityaKhatri

Assignees

@AdityaKhatri AdityaKhatri

@subinasr subinasr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barshathakuri @subinasr @AdityaKhatri