Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordlistProtection and BasicFloodingProtection do not ignore draupnir itself #579

Closed
TheArcaneBrony opened this issue Sep 26, 2024 · 0 comments · Fixed by #651
Closed

WordlistProtection and BasicFloodingProtection do not ignore draupnir itself #579

TheArcaneBrony opened this issue Sep 26, 2024 · 0 comments · Fixed by #651
Labels
bug Something isn't working L4 Most Users Likelihood MPS Follow Up P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T5 Major usability Impairs usability in key scenarios.

Comments

@TheArcaneBrony
Copy link
Contributor

I wish I didn't have to make /ignore itself, causing me to end up with unwanted content unredacted on my end :/
I have WordListProtection configured to trust after 0 (never), already had disabled BasicFloodingProtection for this exact kind of getting stuck in a loop, this might affect other protections aswell:

image
@Gnuxie Gnuxie added bug Something isn't working L4 Most Users Likelihood P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T5 Major usability Impairs usability in key scenarios. MPS Follow Up labels Sep 26, 2024
@nexy7574 nexy7574 mentioned this issue Jan 6, 2025
Merged
Gnuxie pushed a commit that referenced this issue Jan 6, 2025
@nexy7574
Prevent Draupnir triggering its own Flooding & WordList protections (#…
77a14c8 
…651)

Fixes the issue displayed in #579 and #559
(fixes #579, fixes #559)

This PR simply adds a check to the start of the execution chain for WordList and BasicFlooding that just returns an Ok result when the event sender was the client's user ID.
I just tested this and can confirm that this prevents the reported loops in WordList and BasicFlooding, as intended.

---------

Signed-off-by: nexy7574 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working L4 Most Users Likelihood MPS Follow Up P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T5 Major usability Impairs usability in key scenarios.
Projects
Draupnir planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent Draupnir triggering its own Flooding & WordList protections nexy7574/Draupnir
2 participants
@TheArcaneBrony @Gnuxie