Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples for cover editor #38

Open
forresto opened this issue Nov 3, 2015 · 4 comments
Open

examples for cover editor #38

forresto opened this issue Nov 3, 2015 · 4 comments
Labels

Comments

@forresto
Copy link
Contributor

forresto commented Nov 3, 2015

API data examples needed to wire up cover editor:

  • share a tweet, add a comment
  • share a tweet with image, add a comment
  • share a video
  • share an article (image, title, desc), fix spammy title, expand to full post

cc @bergie @jxnblk

@jonnor
Copy link
Contributor

jonnor commented Nov 3, 2015

Can we just add a .cover array, which would work similar as current .content? Array of blocks

@bergie
Copy link
Contributor

bergie commented Nov 3, 2015

@jonnor the "cover editor" deals with starred blocks, so they're already in the content array. And easy to get from there:

coverBlocks = item.content.filter (block) -> block.starred

@jonnor
Copy link
Contributor

jonnor commented Nov 26, 2015

I believe we've settled on API additions/changes now. Any docs that need to be updated? @bergie @jxnblk

@nickvelloff
Copy link

@jonnor @bergie @d4tocchini @jxnblk @ralzaben we did this in the wrong order. ui requirements were not agreed upon, we are back to the req gathering phase. we will need to deliver these when they are solidified. I hope these changes are covered, but I certainly would not assume so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants