Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: unable to save layout in Brave #242

Open
delasource opened this issue Apr 9, 2024 · 3 comments
Open

Bug: unable to save layout in Brave #242

delasource opened this issue Apr 9, 2024 · 3 comments

Comments

@delasource
Copy link

Clicking "Save" does nothing at my side. It shows in console log "User cancelled save file request" but i didnt.
Using Brave, tried with all blockers disabled.
Using Edge or Chrome, it is working.

@bboc
Copy link

bboc commented May 9, 2024

Same issue here, tested on Brave version 1.65.130 on MacOs Sonoma, with a new profile, default settings, no extensions, and all shields disabled. Load button appears to work,though, clicking it displays a dialog for selecting a file.

@potter-man
Copy link

Somehow there is no Window::showSaveFilePicker function in Brave
Issue: brave/brave-browser#29411

It enables with flag File System Access API mentioned in the comment brave/brave-browser#29411 (comment)

@bboc
Copy link

bboc commented May 13, 2024

@potter-man Thanks. I can confirm that enabling the flag opens the download dialog.

I guess we can't expect all Brave users to enable that flag, so the simplest fix I can imagine is testing for Window::showSaveFilePicker, and if that does not exist, simply trigger a download with a default filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants