Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs or spaces #57

Open
jgonggrijp opened this issue Oct 20, 2013 · 5 comments
Open

Tabs or spaces #57

jgonggrijp opened this issue Oct 20, 2013 · 5 comments

Comments

@jgonggrijp
Copy link
Member

@WesleyAC wrote in #54:

Y U USE TABS?
In all seriousness, we should decide if there will be any style guidelines, or if it works, it gets merged. Thoughts?
See the PEP 8.

I think there is no need to establish style guidelines, and anything that works should be merged. The person who merges a pull request has the responsibility to ensure that inconsistent indentation will not be an issue. We certainly learnt our lesson with #53, #55, #56.

That said, if somebody wants to express a different opinion, here's the place.

@WesleyAC
Copy link
Contributor

Seems fine to me, but we'll need to be careful about tab/space mixing.

@lramati
Copy link

lramati commented Oct 20, 2013

I think that we should define tab/space because its a syntax element, but
other than that, we could just say whatever, but I think enforcing pep8
(even if not strictly) will be better long term

@jgonggrijp
Copy link
Member Author

I wrote:

The person who merges a pull request [operator] has the responsibility to ensure that inconsistent indentation will not be an issue.

How about making this more explicit by placing a guideline that the operator should ensure that all indentation is consistent (not mixed)?

@mrhmouse
Copy link
Contributor

I think that requiring consistent indentation throughout a single app or file is reasonable.

@jgonggrijp jgonggrijp added this to the Mature documentation milestone Jun 23, 2014
@jgonggrijp
Copy link
Member Author

I don't think this issue still requires input, but I'm adding it to the documentation milestone and leaving it open to remind us that it should be documented.

@jgonggrijp jgonggrijp self-assigned this Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants